increase protobuffer message size #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
reviewed
Oct 9, 2016
There was a problem hiding this comment.
Looks good to me. But need more reviews.
This change makes trainer_config able to return a large config. It makes PyDataProvider can serialize much more arguments.
But the disadvantages are:
- It will use larger memory to save trainer config. Maybe we can remove
PyDataProvider'sargumentsafter parsing them immediately to solve this problem. ButTrainerConfigin Paddle may have someCopy By Value. It is also need be cleaned. - The problem is not actually solved, because there still is a size limit here.
And related issue is #166
emailweixu
requested changes
Oct 14, 2016
There was a problem hiding this comment.
As we discussed, it's not recommended to transmit large python data structure the TrainerConfig. For dictionary, we can just transmit the file name, and let dataprovider to load it. Please change the demos to this way of handling dictionary instead of increasing protobuf size limit.
This was referenced Dec 5, 2016
Closed
thisjiang
pushed a commit
to thisjiang/Paddle
that referenced
this pull request
Oct 28, 2021
gglin001
pushed a commit
to graphcore/Paddle-fork
that referenced
this pull request
Dec 8, 2021
DesmonDay
pushed a commit
to DesmonDay/Paddle
that referenced
this pull request
Nov 28, 2022
* Modify for experiment * Modify for experiment * Modify for experiment Co-authored-by: root <[email protected]>
zmxdream
pushed a commit
to zmxdream/Paddle
that referenced
this pull request
Dec 7, 2022
* Modify for experiment * Modify for experiment * Modify for experiment Co-authored-by: root <[email protected]>
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Dec 6, 2023
Missing module in `setup.py`
lizexu123
pushed a commit
to lizexu123/Paddle
that referenced
this pull request
Feb 23, 2024
* fix readme link * fix readme link
WAYKEN-TSE
pushed a commit
to WAYKEN-TSE/Paddle
that referenced
this pull request
Dec 6, 2024
change export code in blip2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.