fix protobuf size limit of seq2seq demo #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luotao1
commented
Dec 5, 2016
luotao1
commented
- fix seq2seq error #718 ：按照increase protobuffer message size #170 ，修改seq2seq中define_py_data_sources2的args参数，将直接传递字典改成传递字典地址，并写入FAQ中。
- 将seq2seq demo中的slots和yield改为显示指定。
|
@qingqing01 Please review this PR. If you want help, then assign me. I think this PR could be reviewed by one person. |
alvations
reviewed
Dec 5, 2016
| settings.job_mode = not is_generating | ||
| settings.src_dict = dict() | ||
| for line_count, line in enumerate(open(src_dict_path, "r")): | ||
| settings.src_dict[line.strip()] = line_count |
There was a problem hiding this comment.
我自己的seqToseq代码用dictionary comprehension来初设化 src_dict 和 trg_dict。这样初设化会比较pythonic 吧 =）
with open(src_dict_path, "r") as fin:
settings.src_dict = {line.strip():line_count for line_count, line in enumerate(fin)}
alvations
reviewed
Dec 5, 2016
| settings.trg_dict = dict() | ||
| for line_count, line in enumerate(open(trg_dict_path, "r")): | ||
| settings.trg_dict[line.strip()] = line_count | ||
|
|
There was a problem hiding this comment.
同样的
with open(trg_dict_path, "r") as fin:
settings.trg_dict = {line.strip():line_count for line_count, line in enumerate(fin)}
qingqing01
approved these changes
Dec 5, 2016
| settings.trg_dict = { | ||
| line.strip(): line_count | ||
| for line_count, line in enumerate(fin) | ||
| } |
Merged
wangxicoding
pushed a commit
to wangxicoding/Paddle
that referenced
this pull request
Dec 9, 2021
111行if语句写错了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.