refactor(hardware): constants from firmware #8995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipenv can add git repo dependencies, so we can add the opentrons_ot3_firmware repo here. If you want to switch branches you can edit the pipfile (there's not really a better way to do this). This will become a problem if we ever want to depend on this module and get its transitive dependencies because that stuff only reads setup.py, but we don't really do that yet.
This lets us take a bunch of code out how nice
sfoster1
requested review from
amitlissack,
ahiuchingau,
sotaoverride and
Laura-Danielle
Codecov Report
@@ Coverage Diff @@
## edge #8995 +/- ##
==========================================
+ Coverage 74.72% 74.74% +0.01%
==========================================
Files 1860 1861 +1
Lines 49407 49573 +166
Branches 4857 4931 +74
==========================================
+ Hits 36918 37051 +133
- Misses 11644 11669 +25
- Partials 845 853 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
amitlissack
reviewed
Dec 7, 2021
There was a problem hiding this comment.
Looks good to me. As long as we aren't losing anything from #8772
amitlissack
approved these changes
Dec 7, 2021
sfoster1
added a commit
that referenced
this pull request
Dec 7, 2021
sfoster1
added a commit
that referenced
this pull request
Dec 7, 2021
* chore(hardware): add firmware python module as dep Pipenv can add git repo dependencies, so we can add the opentrons_ot3_firmware repo here. If you want to switch branches you can edit the pipfile (there's not really a better way to do this). This will become a problem if we ever want to depend on this module and get its transitive dependencies because that stuff only reads setup.py, but we don't really do that yet. * chore(hardware): rely on constants from firmware This lets us take a bunch of code out how nice * add pushing to ot3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make hardware rely on opentrons-ot3-firmware.
This adds a pipenv git dependency which means you'll have to re-run install a lot. It needs to be editable but that needs some changes to the pyproject.toml itself (which perhaps indicates a failing of the system).
For now, this will probably work.