refactor(hardware): constants from firmware #9016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore(hardware): add firmware python module as dep Pipenv can add git repo dependencies, so we can add the opentrons_ot3_firmware repo here. If you want to switch branches you can edit the pipfile (there's not really a better way to do this). This will become a problem if we ever want to depend on this module and get its transitive dependencies because that stuff only reads setup.py, but we don't really do that yet. * chore(hardware): rely on constants from firmware This lets us take a bunch of code out how nice * add pushing to ot3
sfoster1
requested review from
amitlissack,
ahiuchingau,
sotaoverride and
Laura-Danielle
Codecov Report
@@ Coverage Diff @@
## edge #9016 +/- ##
==========================================
+ Coverage 74.71% 74.74% +0.02%
==========================================
Files 1861 1862 +1
Lines 49479 49567 +88
Branches 4869 4884 +15
==========================================
+ Hits 36969 37049 +80
- Misses 11662 11666 +4
- Partials 848 852 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This prevents lint failures
| $(sphinx_build) -b latex -d docs/build/doctrees $< $(@D) | ||
| $(sphinx_build_allow_warnings) -b latex -d docs/build/doctrees $< $(@D) |
There was a problem hiding this comment.
Bummer, but 👍 if this fixes spurious/uncontrollable CI stuff.
(Cross-reference for posterity: #6135)
amitlissack
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of #8995 . Don't merge until api tests pass.
Pipenv can add git repo dependencies, so we can add the
opentrons_ot3_firmware repo here.
If you want to switch branches you can edit the pipfile (there's not
really a better way to do this).
This will become a problem if we ever want to depend on this module and
get its transitive dependencies because that stuff only reads setup.py,
but we don't really do that yet.
This lets us take a bunch of code out how nice