Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hardware): Revert #8995 #9014

Merged
merged 2 commits into from
Dec 7, 2021
Merged

fix(hardware): Revert #8995 #9014

merged 2 commits into from
Dec 7, 2021

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Dec 7, 2021

This reverts commit 2205bfb , pr #8995

I didn't properly test this commit and it broke tests in api. Will resubmit once those tests can pass.

@sfoster1 sfoster1 requested review from mcous and amitlissack December 7, 2021 22:28
@sfoster1 sfoster1 requested review from a team as code owners December 7, 2021 22:28
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #9014 (597a646) into edge (fec85cd) will increase coverage by 0.01%.
The diff coverage is 86.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #9014      +/-   ##
==========================================
+ Coverage   74.69%   74.71%   +0.01%     
==========================================
  Files        1861     1861              
  Lines       49457    49479      +22     
  Branches     4868     4869       +1     
==========================================
+ Hits        36944    36969      +25     
+ Misses      11666    11662       -4     
- Partials      847      848       +1     
Flag Coverage Δ
api 84.70% <ø> (+0.01%) ⬆️
app 69.87% <ø> (+0.05%) ⬆️
robot-server 91.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ware/opentrons_hardware/scripts/generate_header.py 0.00% <0.00%> (ø)
hardware/opentrons_hardware/scripts/move.py 0.00% <0.00%> (ø)
...entrons_hardware/drivers/can_bus/arbitration_id.py 88.88% <88.88%> (ø)
...rons_hardware/drivers/can_bus/messages/messages.py 91.66% <91.66%> (ø)
...are/opentrons_hardware/drivers/can_bus/__init__.py 100.00% <100.00%> (ø)
...pentrons_hardware/drivers/can_bus/can_messenger.py 86.27% <100.00%> (ø)
...re/opentrons_hardware/drivers/can_bus/constants.py 100.00% <100.00%> (ø)
...dware/opentrons_hardware/drivers/can_bus/driver.py 83.63% <100.00%> (ø)
...ware/opentrons_hardware/drivers/can_bus/message.py 100.00% <100.00%> (ø)
...rons_hardware/drivers/can_bus/messages/__init__.py 100.00% <100.00%> (ø)
... and 18 more

@sfoster1 sfoster1 merged commit 224f4c2 into edge Dec 7, 2021
@sfoster1 sfoster1 deleted the revert-ot3-firmware branch December 7, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants