Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hardware): Revert "feat(can): add getMoveStatus request & response" #8710

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

ahiuchingau
Copy link
Contributor

Reverts #8688
Going to add current position to the ack message instead.

@ahiuchingau ahiuchingau requested a review from a team November 10, 2021 18:56
@ahiuchingau ahiuchingau requested a review from a team as a code owner November 10, 2021 18:56
@ahiuchingau ahiuchingau changed the title Revert "feat(can): add getMoveStatus request & response" fix(hardware): Revert "feat(can): add getMoveStatus request & response" Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #8710 (f0136b5) into edge (c3bf7ab) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #8710      +/-   ##
==========================================
- Coverage   74.67%   74.66%   -0.01%     
==========================================
  Files        1756     1756              
  Lines       47105    47088      -17     
  Branches     4712     4712              
==========================================
- Hits        35176    35159      -17     
  Misses      11123    11123              
  Partials      806      806              
Flag Coverage Δ
hardware 83.41% <ø> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/opentrons_hardware/drivers/can_bus/constants.py 100.00% <ø> (ø)
...re/drivers/can_bus/messages/message_definitions.py 100.00% <ø> (ø)
...rons_hardware/drivers/can_bus/messages/messages.py 91.66% <ø> (ø)
...rons_hardware/drivers/can_bus/messages/payloads.py 100.00% <ø> (ø)

Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahiuchingau ahiuchingau merged commit bfbab43 into edge Nov 11, 2021
@ahiuchingau ahiuchingau deleted the revert-8688-can_add-move-diagnostic-msg branch November 11, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants