Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(can): add getMoveStatus request & response #8688

Merged
merged 3 commits into from
Nov 9, 2021

Conversation

ahiuchingau
Copy link
Contributor

Overview

This PR allows us to get the status of the currently executed move from a specific node.

Changelog

Review requests

Risk assessment

@ahiuchingau ahiuchingau requested review from amitlissack and a team November 9, 2021 20:47
@ahiuchingau ahiuchingau requested a review from a team as a code owner November 9, 2021 20:47
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #8688 (8451d86) into edge (80093b3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #8688      +/-   ##
==========================================
+ Coverage   75.22%   75.23%   +0.01%     
==========================================
  Files        1208     1208              
  Lines       37931    37948      +17     
  Branches     2792     2792              
==========================================
+ Hits        28535    28552      +17     
  Misses       8995     8995              
  Partials      401      401              
Flag Coverage Δ
hardware 83.84% <100.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rons_hardware/drivers/can_bus/messages/messages.py 91.66% <ø> (ø)
...re/opentrons_hardware/drivers/can_bus/constants.py 100.00% <100.00%> (ø)
...re/drivers/can_bus/messages/message_definitions.py 100.00% <100.00%> (ø)
...rons_hardware/drivers/can_bus/messages/payloads.py 100.00% <100.00%> (ø)

@ahiuchingau ahiuchingau merged commit 4f50044 into edge Nov 9, 2021
@ahiuchingau ahiuchingau deleted the can_add-move-diagnostic-msg branch November 9, 2021 21:38
ahiuchingau added a commit that referenced this pull request Nov 10, 2021
ahiuchingau added a commit that referenced this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants