refactor(emulation): integrated with module control #8586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## emulation-refactor-phase-2 #8586 +/- ##
==============================================================
+ Coverage 75.14% 75.22% +0.07%
==============================================================
Files 1797 1801 +4
Lines 47668 47720 +52
Branches 4648 4648
==============================================================
+ Hits 35820 35897 +77
+ Misses 11047 11022 -25
Partials 801 801
Flags with carried forward coverage won't be shown. Click here to find out more.
|
amitlissack
force-pushed
the
emulation-module-control
branch
from
5d6c134 to
4b3e6b2
Compare
amitlissack
force-pushed
the
emulation-refactor-phase-2
branch
from
12fff3b to
6ae4a1e
Compare
amitlissack
force-pushed
the
emulation-module-control
branch
from
4b3e6b2 to
dfe0d68
Compare
amitlissack
changed the title
amitlissack
force-pushed
the
emulation-module-control
branch
from
605723d to
042ff36
Compare
amitlissack
force-pushed
the
emulation-refactor-phase-2
branch
from
e5ffa15 to
b1c2391
Compare
added 12 commits
October 27, 2021 12:30
amitlissack
force-pushed
the
emulation-module-control
branch
from
f8047fa to
5903b8c
Compare
amitlissack
changed the title
added 2 commits
October 27, 2021 16:12
sfoster1
approved these changes
Oct 29, 2021
| if not api_instance.is_simulator: | ||
| await mc_instance.register_modules(mc_instance.scan()) | ||
| api_instance.loop.create_task( |
There was a problem hiding this comment.
So does this get instantiated in true hardware controllers running in the server on an actual OT2?
There was a problem hiding this comment.
It does. What do you think? Is there possibly a reason to have emulated modules + real modules?
Happy to disable on robot.
added 2 commits
October 29, 2021 10:56
amitlissack
pushed a commit
that referenced
this pull request
Nov 9, 2021
* Module control refactors * new package. * start module control integration. * tests for module control integration. * implement connection listener. * module server integrated into module control. * lint * g-code-testing * redo docker compose to deal with separate emulator apps. * usb port. * expand module emulation settings. * update docker readme. * format-js * lint * go back to threadings. I don't want to debug windows nonsense. * fix bug. * redo gcode testing's emulator setup. * documentation. * clean up.
amitlissack
pushed a commit
that referenced
this pull request
Nov 9, 2021
* proxy. run_emulator * Linting/Formatting * emulator * integration tests pass. * lint passes. * gcode parsing. * gcode parsing uses process for emulator. * run_emulator_client retries. * wait for emulator connection method. * scripts. * utils * g-code-testing lint * refactor(emulation): integrated with module control (#8586) * Module control refactors * new package. * start module control integration. * tests for module control integration. * implement connection listener. * module server integrated into module control. * lint * g-code-testing * redo docker compose to deal with separate emulator apps. * usb port. * expand module emulation settings. * update docker readme. * format-js * lint * go back to threadings. I don't want to debug windows nonsense. * fix bug. * redo gcode testing's emulator setup. * documentation. * clean up. * don't listen for emulators on robot. * chore(gcode): reduce time of gcode-testing (#8683) * faster g-code-tests in ci * reduce hold time. * use dev folder in s3 * wait. Co-authored-by: Derek Maggio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR completes refactor of how our module emulation works.
This is part 2. The hardware controller connects to
ModuleServerto discover emulated modules.This is part 1
This PR opens up hot plugging modules and "multiples of a module" in emulation.
Changelog
Review requests
Tests will not pass due to g-code-testing. The way emulators connect is no longer 100% predictable. This means variation in g-codes.
Risk assessment
None. This is a PR into a feature branch.