chore(gcode): reduce time of gcode-testing #8683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitlissack
force-pushed
the
emulation-refactor-phase-2
branch
from
3198269 to
c58e5eb
Compare
Codecov Report
@@ Coverage Diff @@
## emulation-refactor-phase-2 #8683 +/- ##
==============================================================
+ Coverage 75.34% 76.03% +0.68%
==============================================================
Files 1830 1295 -535
Lines 48566 39504 -9062
Branches 4706 2792 -1914
==============================================================
- Hits 36594 30036 -6558
+ Misses 11172 9067 -2105
+ Partials 800 401 -399
Flags with carried forward coverage won't be shown. Click here to find out more.
|
amitlissack
changed the title
Laura-Danielle
approved these changes
Nov 9, 2021
DerekMaggio
approved these changes
Nov 9, 2021
amitlissack
pushed a commit
that referenced
this pull request
Nov 9, 2021
* proxy. run_emulator * Linting/Formatting * emulator * integration tests pass. * lint passes. * gcode parsing. * gcode parsing uses process for emulator. * run_emulator_client retries. * wait for emulator connection method. * scripts. * utils * g-code-testing lint * refactor(emulation): integrated with module control (#8586) * Module control refactors * new package. * start module control integration. * tests for module control integration. * implement connection listener. * module server integrated into module control. * lint * g-code-testing * redo docker compose to deal with separate emulator apps. * usb port. * expand module emulation settings. * update docker readme. * format-js * lint * go back to threadings. I don't want to debug windows nonsense. * fix bug. * redo gcode testing's emulator setup. * documentation. * clean up. * don't listen for emulators on robot. * chore(gcode): reduce time of gcode-testing (#8683) * faster g-code-tests in ci * reduce hold time. * use dev folder in s3 * wait. Co-authored-by: Derek Maggio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The gcode protocol tests take many minutes to complete. The reasons:
This is a PR into the emulation refactor phase 2 branch. The changes in that branch will require updating the master files in S3. Seemed like a good opportunity to do some optimizations.
Changelog
Review requests
Risk assessment
None