-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api,robot-server): Add Dockerfile and docker-compose file #7836
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #7836 +/- ##
=======================================
Coverage 83.48% 83.49%
=======================================
Files 336 336
Lines 21350 21347 -3
=======================================
- Hits 17824 17823 -1
+ Misses 3526 3524 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Works for me. Left a couple suggestions on how to improve workflow- mostly just prepping for a docker-compose up -d
situation~
This is a general question for everyone -- I've used docker-compose for some personal projects but I can't figure out how to get the CLI to work without having the desktop app open. Is it simply supposed to work like that? Maybe cc @X-sam |
Do you get the old docker daemon not running? |
You need to be running docker desktop, it controls the docker daemon that docker-compose works on. In fact, it's even been integrated with the docker CLI now: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool. I feel like the readme guy, but does it make sense to document the existence of it in the robot-server or tippy top readme?
Dang, READMEGUY, I was just about to do that!!! |
One more bit of wondering, it seems like we could have lots of Docker possibilities. Is the idea that we stick whatever we want to be runnable in the container and use compose to run those services? Seems like a nice means of having a single container that can do anything in our vast store of monorepo possibilities. |
Yes, and specify docker-compose to define entry points and env variables. It's not the only pattern, but it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
READMEGUY likes what you have done.
Co-authored-by: Sam! Bonfante <[email protected]>
Co-authored-by: Sam! Bonfante <[email protected]>
Overview
This adds a
Dockerfile
to the root of the monorepo. It will build a backend in which to run therobot-server
andhardware emulator
.A docker-compose file is added to start the
robot-server
connected to emulators.closes #7674
Changelog
.docker-ignore
to root of monorepoDockerfile
that builds an image with api, robot-server, notify-server and dependencies.docker-compose.yml
to run the robot-server and hardware emulation together.Review requests
To run:
docker-compose up --build
I am no Docker wiz. Any advice is welcome.
If we like this approach I will add some notes in the read me for usage.
Risk assessment
None