-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(shared-data): port shared-data JS source to TypeScript #7731
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #7731 +/- ##
=======================================
Coverage ? 82.77%
=======================================
Files ? 326
Lines ? 21425
Branches ? 0
=======================================
Hits ? 17735
Misses ? 3690
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 💎
@@ -0,0 +1,19 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to call this out because it's a little confusing!
shared-data
now has two separate tsconfig
files: one for TS, and one for JSON. Having a separate config for JSON allows us to ensure the JSON files are output to lib
along with the rest of the .d.ts
files, allowing us to use stuff from JSON, like object keys, directly in TypeScript types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview
This PR converts the JS source of shared-data to TypeScript.
Current status:
Changelog
Review requests
Please check carefully for any source-code changes
Risk assessment
Medium, shared-data is pretty important! Please be on the lookup for unintentional source-code changes in the review. This PR should be limited to type and style change only