Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS cleanup: factor out Mount type to shared-data #7747

Closed
IanLondon opened this issue Apr 30, 2021 · 1 comment · Fixed by #7755
Closed

JS cleanup: factor out Mount type to shared-data #7747

IanLondon opened this issue Apr 30, 2021 · 1 comment · Fixed by #7755
Labels
JS Tech Debt refactor

Comments

@IanLondon
Copy link
Contributor

IanLondon commented Apr 30, 2021 •
edited
Loading

Move Mount type from components to shared-data, then we can remove components as a dependency of step-generation

This is follow-up work after #7702
@mcous
Copy link
Contributor

mcous commented May 2, 2021

This is done in #7731 to resolve a circular dependency in the types that blocked the port

IanLondon added a commit that referenced this issue May 3, 2021
@IanLondon
refactor(step-generation): remove dependency on components
57b61dc 
Closes #7747
@IanLondon IanLondon mentioned this issue May 3, 2021
Merged
IanLondon added a commit that referenced this issue May 4, 2021
@IanLondon
refactor(step-generation): remove dependency on components (#7755)
4221549 
* add missing shared-data dependency in package.json

Closes #7747
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JS Tech Debt refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(step-generation): remove dependency on components Opentrons/opentrons
2 participants
@mcous @IanLondon