Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore TS generated JSON files for linting and formatting #7796

Merged
merged 1 commit into from
May 11, 2021

Conversation

mcous
Copy link
Contributor

@mcous mcous commented May 11, 2021

Overview

#7731 added JSON file "generation" to the TS build to allow stuff from our shared-data JSON blobs to be used in type definitions. Unfortunately, I forgot to add those JSON files to the lint ignore. This PR fixes that oversight.

Changelog

  • chore: ignore TS generated JSON files for linting and formatting

Review requests

  • make build-ts lint-js lint-json does not result in any lint errors

Risk assessment

N/A

@mcous mcous requested a review from a team as a code owner May 11, 2021 20:35
@mcous mcous added the chore label May 11, 2021
Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@mcous mcous merged commit 68273d7 into edge May 11, 2021
@mcous mcous deleted the shared-data_ignore-lib-json branch May 11, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants