Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(protocol-designer): mock file-saver while using cypress #5943

Merged
merged 4 commits into from
Jun 22, 2020

Conversation

IanLondon
Copy link
Contributor

@IanLondon IanLondon commented Jun 17, 2020

overview

Same deal as #5932 but for PD

Closes #5457

changelog

  • mock file-saver for cypress, using webpack
  • define Chrome version in Travis (stable) instead of using implicitly-defined one (it's out-of-date)

review requests

  • PD should allow you to download files (branch build, or make dev)
  • E2E tests should still pass (if running with yarn cypress open, you need to run make -C protocol-designer dev CYPRESS=1. Which is already the case on edge, just implemented differently)

risk assessment

Medium, but easy to check. If I messed something up, PD would not save files.

@IanLondon IanLondon added ready for review protocol designer Affects the `protocol-designer` project labels Jun 17, 2020
@IanLondon IanLondon requested review from mcous, Kadee80, shlokamin and a team June 17, 2020 17:22
@IanLondon IanLondon requested a review from mcous June 18, 2020 15:30
Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed via slack not sure what's going on with travis but looks good

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (edge@07f7180). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #5943   +/-   ##
=======================================
  Coverage        ?   78.95%           
=======================================
  Files           ?      195           
  Lines           ?    18727           
  Branches        ?        0           
=======================================
  Hits            ?    14785           
  Misses          ?     3942           
  Partials        ?        0           
Impacted Files Coverage Δ
opentrons/protocols/bundle.py 92.98% <0.00%> (ø)
...ot-server/robot_server/service/json_api/factory.py 100.00% <0.00%> (ø)
opentrons/api/dev_types.py 0.00% <0.00%> (ø)
opentrons/legacy_api/robot/mover.py 88.63% <0.00%> (ø)
opentrons/protocol_api/geometry.py 96.17% <0.00%> (ø)
opentrons/drivers/rpi_drivers/types.py 82.92% <0.00%> (ø)
opentrons/system/smoothie_update.py 50.00% <0.00%> (ø)
opentrons/legacy_api/robot/__init__.py 100.00% <0.00%> (ø)
opentrons/drivers/thermocycler/driver.py 49.86% <0.00%> (ø)
opentrons/drivers/serial_communication.py 28.57% <0.00%> (ø)
... and 185 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07f7180...d39d330. Read the comment docs.

@IanLondon IanLondon requested a review from a team as a code owner June 19, 2020 15:09
@@ -1,6 +1,9 @@
# opentrons platform travis config
cache: false

addons:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't figure out what version of Chrome was installed in Travis before, but it didn't have Blob.text fn (so the default Chrome installed was at least ~1 year old??), this kept failing the E2E tests with "text is not a function" (Blob.text fn is used in the Cypress test itself, not used in PD app code)

@IanLondon IanLondon merged commit 3f1c7f6 into edge Jun 22, 2020
@IanLondon IanLondon deleted the pd_mock-cypress-filesave-in-webpack branch June 22, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol designer Affects the `protocol-designer` project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS: Mock FileSaver when using Cypress
3 participants