-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(protocol-designer): mock file-saver while using cypress #5943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed via slack not sure what's going on with travis but looks good
Codecov Report
@@ Coverage Diff @@
## edge #5943 +/- ##
=======================================
Coverage ? 78.95%
=======================================
Files ? 195
Lines ? 18727
Branches ? 0
=======================================
Hits ? 14785
Misses ? 3942
Partials ? 0
Continue to review full report at Codecov.
|
@@ -1,6 +1,9 @@ | |||
# opentrons platform travis config | |||
cache: false | |||
|
|||
addons: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't figure out what version of Chrome was installed in Travis before, but it didn't have Blob.text
fn (so the default Chrome installed was at least ~1 year old??), this kept failing the E2E tests with "text is not a function" (Blob.text
fn is used in the Cypress test itself, not used in PD app code)
overview
Same deal as #5932 but for PD
Closes #5457
changelog
stable
) instead of using implicitly-defined one (it's out-of-date)review requests
make dev
)yarn cypress open
, you need to runmake -C protocol-designer dev CYPRESS=1
. Which is already the case onedge
, just implemented differently)risk assessment
Medium, but easy to check. If I messed something up, PD would not save files.