You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's bad to modify application code to support tests, let's avoid it!
Acceptance criteria
Remove references to process.env.CYPRESS / global.Cypress from PD/LC application code
Rely on webpack to mock FileSaver when process.env.CYPRESS === '1'
Implementation details
This override should happen using a mock for FileSaver that webpack (using the resolve) config or babel (using babel-plugin-module-resolver) shims in when the environment is Cypress rather than putting the override logic in application code
Overview
It's bad to modify application code to support tests, let's avoid it!
Acceptance criteria
process.env.CYPRESS
/global.Cypress
from PD/LC application codeFileSaver
whenprocess.env.CYPRESS === '1'
Implementation details
This override should happen using a mock for
FileSaver
that webpack (using the resolve) config or babel (using babel-plugin-module-resolver) shims in when the environment is Cypress rather than putting the override logic in application codehttps://github.com/_render_node/MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDQxMjM2NzQ3Ng==/comments/review_comment_
The text was updated successfully, but these errors were encountered: