test(labware-library): mock file-saver while using cypress #5932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses LC side of #5457
IanLondon
commented
Jun 16, 2020
| @@ -30,6 +30,13 @@ const envVars = passThruEnvVars.reduce( | |||
| { ...envVarsWithDefaults } | |||
| ) | |||
|
|
|||
| const testAliases = | |||
| process.env.CYPRESS === '1' | |||
| ? { | |||
There was a problem hiding this comment.
if we needed any more E2E mocks, we'd add them here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Addresses LC side of #5457. If we like this approach, I'll repeat it for PD's use of
file-saverto close that issueNote: I think we have a ticket somewhere for not having mu's in the filenames, but I didn't want to address that in this PR, too separate of a concern to fit in here. Plus now that we have a test for the file name, we can TDD that when we get to it 🙃
changelog
review requests
make -C labware-library dev), you should be able to save labware files in LC normallymake -C labware-library test-e2emake -C labware-library dev CYPRESS=1then when that's running, in another tab,cd labware-library; yarn cypress openrisk assessment
Low, if it goes really wrong this would block file download in LC, but should be easy to prove that this is still working or not (eg try to d/l in sandbox)