refactor(app): add move, positions, and disengage calls to robot-controls #4651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This PR follows up on the refactor work completed in #4440, #4477, #4544, #4599, #4615, #4631, #4646. The endpoints being recreated today are:
GET /robot/positions
POST /robot/move
POST /motors/disengage
This PR does not wire up these actions because it will involve a fairly heavy rewrite of Change Pipette. That will be its own PR. As of this PR, all necessary endpoints for the wizard are in the new epic-based
robot-controls
module!changelog
app/src/robot-controls
move
+ success / failure)state.robotControls
reducermoveEpic
) that:review requests
Since this PR doesn't wire anything up to the UI, we can save functional testing for that upcoming PR. For this one, please make sure the code and added unit tests look reasonable!
If you have a robot handy, though, you can try this out in the redux devtools. Just make sure that the robot's attached pipettes are already in state
You should see the API calls in the network monitor. If
disengageMotors
istrue
, you should be able to move the pipette by hand once the calls complete. Afterwards, you should see arobotControls:MOVE_SUCCESS
in the devtools.