-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app,pd): Truncate long labware names #3644
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #3644 +/- ##
==========================================
+ Coverage 29.04% 29.22% +0.18%
==========================================
Files 733 733
Lines 13278 13329 +51
==========================================
+ Hits 3857 3896 +39
- Misses 9421 9433 +12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔬 🐘
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✂️ 🔬 🏷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Protocol code looks fine
overview
The displayNames (and loadNames) in labware v2 tend to be much longer than those in v1, which means some of our less well constrained UI components are more likely to misbehave.
This fixes #3617 to ensure that wherever labware names get placed in the UI in the app and PD, they get truncated rather that wrap and cause weird display issues.
changelog
<TitleBar>
in the CL, so please test carefullyapi
to use new labware names so I could testreview requests
TitleBar
s in app behave regardless of if they are for labwareTitleBar
s in PD behave regardless of if they are for labware