Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app,pd): Truncate long labware names #3644

Merged
merged 5 commits into from
Jun 27, 2019
Merged

fix(app,pd): Truncate long labware names #3644

merged 5 commits into from
Jun 27, 2019

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Jun 27, 2019

overview

The displayNames (and loadNames) in labware v2 tend to be much longer than those in v1, which means some of our less well constrained UI components are more likely to misbehave.

This fixes #3617 to ensure that wherever labware names get placed in the UI in the app and PD, they get truncated rather that wrap and cause weird display issues.

  • App labware calibration
    • Side panel labware list
    • Calibration wizard title bar
  • PD deck setup
    • Edit liquids + labware name title bar

changelog

  • Truncate long labware names in App and PD
    • To do this, I had to edit <TitleBar> in the CL, so please test carefully
  • Other related fixes enabled by ^ and the addition of labware v2 definitions to the app
  • Updated a couple example protocols in api to use new labware names so I could test
    • Ping @Opentrons/py

review requests

  • App
    • App items listed above behave when using a v1 labware protocol
    • App items listed above behave when using a v2 labware protocol
    • All TitleBars in app behave regardless of if they are for labware
  • PD
    • Edit liquids and name wizard truncates long names properly
    • All TitleBars in PD behave regardless of if they are for labware
  • API
    • Test protocol updates are sane

@mcous mcous added bug app Affects the `app` project fix PR fixes a bug protocol designer Affects the `protocol-designer` project labels Jun 27, 2019
@mcous mcous requested review from Kadee80, IanLondon and a team June 27, 2019 17:47
@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #3644 into edge will increase coverage by 0.18%.
The diff coverage is 12.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #3644      +/-   ##
==========================================
+ Coverage   29.04%   29.22%   +0.18%     
==========================================
  Files         733      733              
  Lines       13278    13329      +51     
==========================================
+ Hits         3857     3896      +39     
- Misses       9421     9433      +12
Impacted Files Coverage Δ
components/src/structure/TitleBar.js 100% <ø> (ø) ⬆️
...omponents/src/instrument-diagram/InstrumentInfo.js 100% <ø> (ø) ⬆️
components/src/modals/ModalPage.js 100% <ø> (ø) ⬆️
app/src/components/ChangePipette/index.js 0% <ø> (ø) ⬆️
app/src/components/CalibrationInfoBox.js 0% <ø> (ø) ⬆️
app/src/components/ReviewDeck/Prompt.js 0% <0%> (ø) ⬆️
...pp/src/components/FileInfo/ProtocolPipettesCard.js 0% <0%> (ø) ⬆️
...rotocol-designer/src/step-forms/selectors/index.js 22.9% <0%> (ø) ⬆️
...pp/src/components/CalibrateLabware/ConfirmModal.js 0% <0%> (ø) ⬆️
...p/src/components/CalibratePanel/PipetteListItem.js 0% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed6c2a7...b10a4af. Read the comment docs.

Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔬 🐘

app/src/components/CalibrateLabware/ConfirmModal.js Outdated Show resolved Hide resolved
@mcous mcous removed the bug label Jun 27, 2019
@mcous mcous removed this from the Labware 2: V2 Labware in PD and RA milestone Jun 27, 2019
Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️ 🔬 🏷

Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Protocol code looks fine

@mcous mcous merged commit abe4bc7 into edge Jun 27, 2019
@mcous mcous deleted the app_long-labware-names branch June 27, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project fix PR fixes a bug protocol designer Affects the `protocol-designer` project
Projects
None yet
4 participants