Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 3.4.0 #2338

Merged
merged 1 commit into from
Sep 21, 2018
Merged

chore(release): 3.4.0 #2338

merged 1 commit into from
Sep 21, 2018

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Sep 20, 2018

overview

Release PR for 3.4.0

changelog

review requests

Standard release review. @umbhau could use your 👍 on the release notes

Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -3,6 +3,31 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

<a name="3.4.0"></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot PD had a changelog, kind of weirdly partitioned right now b/c it's got an independent release cycle

@@ -3,6 +3,15 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

<a name="3.4.0"></a>
# [3.4.0](https://github.com/Opentrons/opentrons/compare/v3.4.0-beta.0...v3.4.0) (2018-09-20)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this is a weirdo changelog too, haha

app-shell/build/release-notes.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested everything I could on VS

sfoster1
sfoster1 approved these changes Sep 20, 2018
@mcous
Copy link
Contributor Author

mcous commented Sep 20, 2018

Summary of findings on Aluminum block testing:

img_20180920_160452

Consensus is that the definitions problems in ...block-96-PCR-plate and ...block-PCR-strips are:

  • fixable via calibration and protocol workarounds
  • wrong in a manner that does not result in collisions

It's ok to proceed with release with these issues noted in the release notes and a plan to (actually) fast-follow with a patch. Overall reliability improvements outweigh labware definition issues in this case

Edit: nevermind, we're fixing them. Release is blocked until then

@codecov
Copy link

codecov bot commented Sep 20, 2018

Codecov Report

Merging #2338 into edge will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #2338   +/-   ##
=======================================
  Coverage   30.01%   30.01%           
=======================================
  Files         508      508           
  Lines        8126     8126           
=======================================
  Hits         2439     2439           
  Misses       5687     5687

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c1e4c2...986ee48. Read the comment docs.

@mcous mcous added the blocked Ticket or PR is blocked by other work label Sep 20, 2018
@mcous mcous removed the blocked Ticket or PR is blocked by other work label Sep 21, 2018
@mcous
Copy link
Contributor Author

mcous commented Sep 21, 2018

I have in-person 👍s from @btmorr and @umbhau and my checks have all passed, so this is going out!

@mcous mcous merged commit 57636e5 into edge Sep 21, 2018
@mcous mcous deleted the release_3.4.0 branch September 21, 2018 16:08
b-cooper added a commit that referenced this pull request Sep 26, 2018
* fix(app): Open external links in browser instead of app window (#2327)

* feat(api): Remove deck calibration from reset options (#2330)

Remove deck calibration from factory reset options, as deck calibration reset should not be done
outside of the context of recalibration

* docs(contributing): Ask Windows users to set core.autocrlf=input (#2332)

Setting core.autocrlf to something that inserts carriage returns on windows means that API pushes to
robots from windows will have carriage returns in the scripts in api/opentrons/resources, which
prevents the robot from booting.

Closes #2305

* fix(api): Update definitions for tuberacks (#2317)

* fix(api): Update definitions for 15ml tuberack, 50ml tuberack, and 15/50ml tuberack to match actual

Closes #2290

* Modify definitions based on practical test

* feat(app): Enable autoupdate on Linux by switching to AppImage builds (#2329)

Closes #2303

* chore(chore): add exception in gitattributes for our hex files (#2339)

* fix(protocol-designer): fix whitescreen on deleting blowout labware (#2341)

* fix unticketed bug: setting blowout to a trash-box in a step and deleting the trash box caused
whitescreen
*make labware dropdown blank when nonexistent labware selected

* fix(api): Update the aluminum block definitions to match drawings (#2342)

* fix(api): Update the aluminum block definitions to match drawings and experiments
* Rename definition in shared-data to match rename in default_containers.json and fix z height
* Closes #2292

* chore(release): 3.4.0 (#2338)

* fix(protocol-designer): fix tiprack diagram only displaying right (#2340)

Fix a small bug where the tiprack diagram in the new file modal would duplicate the diagram of the
selected right pipette tiprack instead of showing both selections.

* feat(api): add module firmware update endpoint (#2173)

Closes #1654 
Adds firmware update api methods and update server functions (for modules with old as well as new bootloader)
Adds a udev rule for new bootloader
Adds tests for modules and update_server endpoint

* feat(protocol-designer): add "app build date" field to PD saved files (#2350)

* chore(api): Cleanup unused api root level files (#2336)

There were some leftovers from days of old: we don't use pip or anaconda or PyInstaller anymore.

* refactor(api): invert control of system and server (#2318)

Closes #2185
Separates out the previously entangled server and system functions so that opentrons.main handles system configuration while server.main only configures and runs the server. Entrypoint is switched from opentrons.server.main to opentrons.main

* feat(api): Add hardware_control submodule (#2349)

The hardware_control submodule is the controller of the robot's hardware. Its API can move the robot at a level of abstraction that portrays the robot as a whole, not including the labware. In this PR, the module is a stub, and not used by default

Closes #2232

* fixup: More verbose names for file and thread locks
* fixup: use functools.wraps in log_call decorator

* ci(codecov): Fix uploading of python coverage (#2360)

* fix(protocol-designer): tweak analytics copy for accuracy (#2366)

Update the copy in the analytics disclaimer to accurately portray our data collection in beta.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants