Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labware Definition Issue: 96-pcr Aluminum Block #2292

Closed
umbhau opened this issue Sep 17, 2018 · 4 comments
Closed

Labware Definition Issue: 96-pcr Aluminum Block #2292

umbhau opened this issue Sep 17, 2018 · 4 comments
Assignees
@btmorr
Labels
api Affects the `api` project bug
Milestone
Bugs

Comments

@umbhau
Copy link

umbhau commented Sep 17, 2018 •
edited
Loading

Labware definition for 96-pcr aluminum block is slightly off.

Expected:

  • Pipette should move to center of well during labware calibration

Observed:

  • Pipette moves too far back and left during labware calibration (not above well at all)

Steps to Recreate

  • Perform robot deck calibration
  • Load a protocol with 96-pcr aluminum block
  • Configure deck with aluminum block on temp deck and pcr plate on aluminum block
  • Perform labware calibration and observe pipette move outside of well

Note this was only observed with the 96-pcr (other aluminum blocks are better)
@umbhau umbhau added bug api Affects the `api` project labels Sep 17, 2018
@umbhau umbhau added this to the Bugs milestone Sep 17, 2018
@umbhau
Copy link
Author

umbhau commented Sep 17, 2018

FYI @Laura-Danielle @btmorr

2 of 2 labware issues @mcous and I found while testing 3.4.0 labware updates. Let's consider this high priority and blocking 3.4.0 production release (and therefore use of new aluminum blocks)

@btmorr btmorr self-assigned this Sep 19, 2018
@btmorr
Copy link
Contributor

btmorr commented Sep 20, 2018

For reference:

lsr_hardshell_96_lp_skirted_spec_web

The aluminum block adds 2.75mm to the height of the labware

@btmorr
Copy link
Contributor

btmorr commented Sep 20, 2018

Strips for reference:

96-pcr-strip

@btmorr
Copy link
Contributor

btmorr commented Sep 20, 2018

It also appears that (in the existing labware definition system) we need to offset from the x and y of the machine drawings by -1mm and -6mm respectively, based on practical experimentation on multiple robots.

btmorr added a commit that referenced this issue Sep 20, 2018
@btmorr
fix(api): Update the aluminum block definitions to match drawings and…
5e82cc9 
… experiments

Closes #2292
btmorr added a commit that referenced this issue Sep 20, 2018
@btmorr
fix(api): Update the aluminum block definitions to match drawings and…
3e5177c 
… experiments

Closes #2292
@btmorr btmorr mentioned this issue Sep 20, 2018
Merged
3 tasks
btmorr added a commit that referenced this issue Sep 20, 2018
@btmorr
fix(api): Update the aluminum block definitions to match drawings and…
f6024cf 
… experiments

Closes #2292
btmorr added a commit that referenced this issue Sep 21, 2018
@btmorr
fix(api): Update the aluminum block definitions to match drawings (#2342
4c1e4c2 
)

* fix(api): Update the aluminum block definitions to match drawings and experiments
* Rename definition in shared-data to match rename in default_containers.json and fix z height
* Closes #2292
b-cooper added a commit that referenced this issue Sep 26, 2018
@b-cooper
Update Protocol Designer Beta Production (#2352)
7b31543 
* fix(app): Open external links in browser instead of app window (#2327)

* feat(api): Remove deck calibration from reset options (#2330)

Remove deck calibration from factory reset options, as deck calibration reset should not be done
outside of the context of recalibration

* docs(contributing): Ask Windows users to set core.autocrlf=input (#2332)

Setting core.autocrlf to something that inserts carriage returns on windows means that API pushes to
robots from windows will have carriage returns in the scripts in api/opentrons/resources, which
prevents the robot from booting.

Closes #2305

* fix(api): Update definitions for tuberacks (#2317)

* fix(api): Update definitions for 15ml tuberack, 50ml tuberack, and 15/50ml tuberack to match actual

Closes #2290

* Modify definitions based on practical test

* feat(app): Enable autoupdate on Linux by switching to AppImage builds (#2329)

Closes #2303

* chore(chore): add exception in gitattributes for our hex files (#2339)

* fix(protocol-designer): fix whitescreen on deleting blowout labware (#2341)

* fix unticketed bug: setting blowout to a trash-box in a step and deleting the trash box caused
whitescreen
*make labware dropdown blank when nonexistent labware selected

* fix(api): Update the aluminum block definitions to match drawings (#2342)

* fix(api): Update the aluminum block definitions to match drawings and experiments
* Rename definition in shared-data to match rename in default_containers.json and fix z height
* Closes #2292

* chore(release): 3.4.0 (#2338)

* fix(protocol-designer): fix tiprack diagram only displaying right (#2340)

Fix a small bug where the tiprack diagram in the new file modal would duplicate the diagram of the
selected right pipette tiprack instead of showing both selections.

* feat(api): add module firmware update endpoint (#2173)

Closes #1654 
Adds firmware update api methods and update server functions (for modules with old as well as new bootloader)
Adds a udev rule for new bootloader
Adds tests for modules and update_server endpoint

* feat(protocol-designer): add "app build date" field to PD saved files (#2350)

* chore(api): Cleanup unused api root level files (#2336)

There were some leftovers from days of old: we don't use pip or anaconda or PyInstaller anymore.

* refactor(api): invert control of system and server (#2318)

Closes #2185
Separates out the previously entangled server and system functions so that opentrons.main handles system configuration while server.main only configures and runs the server. Entrypoint is switched from opentrons.server.main to opentrons.main

* feat(api): Add hardware_control submodule (#2349)

The hardware_control submodule is the controller of the robot's hardware. Its API can move the robot at a level of abstraction that portrays the robot as a whole, not including the labware. In this PR, the module is a stub, and not used by default

Closes #2232

* fixup: More verbose names for file and thread locks
* fixup: use functools.wraps in log_call decorator

* ci(codecov): Fix uploading of python coverage (#2360)

* fix(protocol-designer): tweak analytics copy for accuracy (#2366)

Update the copy in the analytics disclaimer to accurately portray our data collection in beta.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btmorr btmorr

Labels
api Affects the `api` project bug
Projects
None yet
Milestone
Bugs
Development

No branches or pull requests
2 participants
@umbhau @btmorr