refactor(app): Use generic actions in /calibration API module #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the module specific api:CAL_REQUEST, etc actions in favor of api:REQUEST, etc. Making the calibration module more generic also meant moving the jog step size out of redux and into the state of the JogControls component, as had been discussed with @b-cooper
Codecov Report
@@ Coverage Diff @@
## edge #1819 +/- ##
==========================================
+ Coverage 34.22% 34.26% +0.03%
==========================================
Files 370 370
Lines 6069 6074 +5
==========================================
+ Hits 2077 2081 +4
- Misses 3992 3993 +1
Continue to review full report at Codecov.
|
IanLondon
approved these changes
Jul 5, 2018
| const DEFAULT_JOG_STEP = 0.1 | ||
| // TODO(mc, 2018-07-05): flow helper until we have one reducer, since | ||
| // p === 'constant' checks but p === CONSTANT does not, even if | ||
| // CONSTANT is defined as `const CONSTANT: 'constant' = 'constant'` |
There was a problem hiding this comment.
yup I ran into the same thing
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This PR removes the
calibration.jsmodule specificapi:CAL_REQUEST, etc actions in favor ofthe new, generic
api:REQUEST, etc actions. Making the calibration module more generic also meant moving the jog step size out of redux and into the state of theJogControlscomponent, as had been discussed with @b-cooper.This PR is prep work for a
modules.jsAPI client module for #1735 and continues work started in #1813.changelog
review requests
The following peices of logic have been touched, and we should verify all is still well:
/calibration/deck/startresponse state