Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): Refactor /health modules to use generic API actions #1826

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Jul 6, 2018

overview

This PR continues the work of #1813 and #1819 by switching the /health API client module over to generic API actions. As part of this effort, the health-check module was moved to be a sibling rather than child of the API reducer to separate the states in preparation for a simplified API reducer.

changelog

  • refactor(app): Refactor /health modules to use generic API actions

review requests

Stuff that was touched:

  • Health check routine for connected robot (and offline detection)
    • I like to test this by connecting to a robot and then turning off wifi or killing the VS process
  • Robot information card
  • Robot update logic and notification
    • I test this by bumping the version in app-shell/package.json before launching make -C app dev

I tested on Sunset and it looked good to me

This all l

@mcous mcous added app Affects the `app` project ready for review refactor labels Jul 6, 2018
@mcous mcous requested review from Kadee80, b-cooper and IanLondon July 6, 2018 15:31
@codecov
Copy link

codecov bot commented Jul 6, 2018

Codecov Report

Merging #1826 into edge will increase coverage by 0.19%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #1826      +/-   ##
==========================================
+ Coverage   34.26%   34.45%   +0.19%     
==========================================
  Files         370      370              
  Lines        6074     6098      +24     
==========================================
+ Hits         2081     2101      +20     
- Misses       3993     3997       +4
Impacted Files Coverage Δ
app/src/config/index.js 45.45% <ø> (ø) ⬆️
app/src/http-api-client/client.js 93.75% <ø> (ø) ⬆️
app/src/http-api-client/index.js 100% <ø> (ø) ⬆️
app/src/components/LostConnectionAlert/index.js 0% <0%> (ø) ⬆️
app/src/index.js 0% <0%> (ø) ⬆️
app/src/reducer.js 0% <0%> (ø) ⬆️
app/src/health-check/index.js 98.36% <100%> (ø)
app/src/http-api-client/server.js 82.19% <100%> (+0.24%) ⬆️
app/src/robot/reducer/connection.js 92% <75%> (-3.66%) ⬇️
app/src/http-api-client/health.js 94.11% <96.29%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79fe236...478d529. Read the comment docs.

Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, works on VS

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏥 🤖

@mcous mcous merged commit 1425fc3 into edge Jul 9, 2018
@mcous mcous deleted the app_refactor-health-check-state branch July 9, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants