chore(python): Various small Python build and dependency fixes #15720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-testing, hardware-testing, performance-metrics, and test-data-generation are also missing, but that makes sense because they're special things that we treat as sort of off to the side.
shared-data/python's setup.py's constraint did not overlap with its Pipfile's constraint, causing `pipenv lock --dev` to fail. Separately, api's exact version number pin did not match shared-data's exact version number pin. buildroot uses the one that api specifies, so this changes shared-data's to match that.
This was preventing `pipenv lock` and `make setup` on macOS.
This did not match shared-data's constraint, causing `pipenv lock` failures.
DerekMaggio
approved these changes
Jul 22, 2024
|
CI shows linting failing in |
Something about the Pydantic upgrade was interacting poorly with Mypy. Despite these fields having defaults, Mypy was raising errors when the class was instantiated without them. Somehow, declaring the defaults as keyword arguments instead of positional arguments fixes it. Also fix a typo, `descript` -> `description`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix various small things about our Python build system and dev environments that I encountered while working on #15706.
Test Plan
Make sure CI keeps passing.
Changelog
See the individual commit messages.
Risk assessment
Low.