Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python): Hackishly fix packaging import #15706

Closed
wants to merge 1 commit into from
Closed

chore(python): Hackishly fix packaging import #15706

wants to merge 1 commit into from

Conversation

SyntaxColoring
Copy link
Contributor

Overview

This is a quick and dirty fix for CI failures like this one.

Test Plan

  • Uhh does this fix it?

Review requests

Is this too bad of an idea?

Risk assessment

Low.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner July 18, 2024 17:33
@SyntaxColoring SyntaxColoring changed the title chore(python): Hackishly fix packaging import t chore(python): Hackishly fix packaging import Jul 18, 2024
sfoster1
sfoster1 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Hate it. Sadly we must.

@SyntaxColoring
Copy link
Contributor Author

SyntaxColoring commented Jul 18, 2024 •
edited
Loading

Ech, looks like this isn't working either, apparently dependent on setuptools's 71.0.x patch version. There is an actively accumulating list of 71.0.x hotfixes, most recently 30 minutes ago.

I'm going to try to just install packaging properly, as discussed in Slack.

@SyntaxColoring
Copy link
Contributor Author

Superseded by #15717.

@SyntaxColoring SyntaxColoring deleted the hack_to_import_packaging_again branch July 19, 2024 17:06
@SyntaxColoring SyntaxColoring mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SyntaxColoring @sfoster1