Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): Revert jsonschema updates to fix snapshot tests #15759

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Jul 23, 2024

Overview

Some analysis snapshot tests are failing indicating a jsonschema-related error. (e.g. #15750).

I think this is a problem introduced by commit 8f2583f, PR #15720. This PR reverts that until we understand more.

Test Plan

See: #15759 (comment)

Review requests

None.

Risk assessment

Who knows, at this point.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.68%. Comparing base (0a4b774) to head (f4766a7).
Report is 7 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #15759      +/-   ##
==========================================
- Coverage   63.70%   63.68%   -0.03%     
==========================================
  Files         300      300              
  Lines       15649    15653       +4     
==========================================
- Hits         9969     9968       -1     
- Misses       5680     5685       +5     
Flag Coverage Δ
g-code-testing 92.43% <ø> (ø)
hardware 55.73% <100.00%> (-0.05%) ⬇️
shared-data 75.91% <ø> (+0.05%) ⬆️
system-server 94.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...are/opentrons_hardware/drivers/can_bus/settings.py 95.77% <100.00%> (ø)

... and 10 files with indirect coverage changes

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. That hardware testing failure is also in edge.

@SyntaxColoring SyntaxColoring force-pushed the quickly_unbreak_jsonschema branch from 227c943 to f4766a7 Compare July 23, 2024 17:29
@SyntaxColoring
Copy link
Contributor Author

SyntaxColoring commented Jul 23, 2024

Here's a command to help test this locally, which roughly mimics what analyses-snapshot-testing's Dockerfile does:

rm -rf venv &&
python -m venv venv &&
venv/bin/pip install -U ../shared-data/python '../hardware[flex]' ../api pandas==1.4.3 && 
venv/bin/python -m opentrons.cli analyze --human-json-output - /Users/maxmarrone/Code/Opentrons/opentrons/analyses-snapshot-testing/files/protocols/OT2_S_v3_P300SGen1_None_Gen1PipetteSimple.json

Bisecting with this points to commit 8f2583f as the culprit, and confirms that reverting it, like this PR does, fixes it. But the analyses-snapshot-testing workflows running on this PR show it not fixing it. Something weird is going on there.

I'm going to merge this, trusting my local bisect over our CI environments. I suspect something confusing is happening with the way the workflow chooses the refs to test?

@SyntaxColoring SyntaxColoring marked this pull request as ready for review July 23, 2024 17:36
@SyntaxColoring SyntaxColoring requested review from a team as code owners July 23, 2024 17:36
@SyntaxColoring SyntaxColoring merged commit 02acbe1 into edge Jul 23, 2024
122 of 126 checks passed
@SyntaxColoring
Copy link
Contributor Author

Yep, looks like it's fixed now that this is in edge.

@SyntaxColoring SyntaxColoring deleted the quickly_unbreak_jsonschema branch July 23, 2024 17:53
@Opentrons Opentrons deleted a comment from github-actions bot Jul 23, 2024
@Opentrons Opentrons deleted a comment from github-actions bot Jul 23, 2024
@Opentrons Opentrons deleted a comment from github-actions bot Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants