fix(hardware-testing): 96ch diagnostics tip presence polarity #14324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
reviewed
Jan 17, 2024
| @@ -82,14 +82,14 @@ async def run(api: OT3API, report: CSVReport, section: str) -> None: | |||
| slot_5 = helpers_ot3.get_slot_calibration_square_position_ot3(5) | |||
| home_pos = await api.gantry_position(OT3Mount.LEFT) | |||
| await api.move_to(OT3Mount.LEFT, slot_5._replace(z=home_pos.z)) | |||
| for expected_state in [False, True]: | |||
| for expected_state in [True, False]: | |||
There was a problem hiding this comment.
Wait if you switch this order but also switch the else/if order below this doesn't really do anything right? You're still expecting it to be False with no tips (but now that's second) and True with tips (but now that's first)
There was a problem hiding this comment.
but actually, the responds of "get tip status" change, so the results will be different, I want to do the same action to keep the SOP same.
There was a problem hiding this comment.
looks correct to me @sfoster1 . We are now first expecting True, and when it is true that means there are no tips. The ordering of the if/else is arbitrary
hardware-testing/hardware_testing/production_qc/ninety_six_assembly_qc_ot3/test_droplets.py
Show resolved
Hide resolved
sfoster1
approved these changes
Jan 29, 2024
| @@ -82,14 +82,14 @@ async def run(api: OT3API, report: CSVReport, section: str) -> None: | |||
| slot_5 = helpers_ot3.get_slot_calibration_square_position_ot3(5) | |||
| home_pos = await api.gantry_position(OT3Mount.LEFT) | |||
| await api.move_to(OT3Mount.LEFT, slot_5._replace(z=home_pos.z)) | |||
| for expected_state in [False, True]: | |||
| for expected_state in [True, False]: | |||
andySigler
deleted the
fix-hardware-testing-96ch-diagnostics-tip-presence-polarity
branch
ryanthecoder
pushed a commit
that referenced
this pull request
Jan 31, 2024
ncdiehl11
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Polarity when reading 96ch tip-presence sensor was switched at some point, and so the production script must also switch to match it.
Test Plan
Changelog
Review requests
Risk assessment