Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hardware-testing): 96ch diagnostics tip presence polarity #14324

Merged
merged 3 commits into from
Jan 29, 2024
Merged

fix(hardware-testing): 96ch diagnostics tip presence polarity #14324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c948b28
fix status of tip sensor
Andiiiiiiyy Jan 17, 2024
6428626
change the trash_slot position for running 96ch protocol test
Andiiiiiiyy Jan 17, 2024
863d18b
formatting
andySigler Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hardware-testing/hardware_testing/production_qc/ninety_six_assembly_qc_ot3/test_droplets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
TIP_RACK_96_SLOT = 4
TIP_RACK_PARTIAL_SLOT = 5
RESERVOIR_SLOT = 2
TRASH_SLOT = 1
TRASH_SLOT = 12
andySigler marked this conversation as resolved.
Show resolved Hide resolved

TRASH_HEIGHT = 40 # DVT trash
TIP_RACK_96_ADAPTER_HEIGHT = 11 # DVT adapter
Expand Down
6 changes: 3 additions & 3 deletions ...ware-testing/hardware_testing/production_qc/ninety_six_assembly_qc_ot3/test_tip_sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,14 @@ async def run(api: OT3API, report: CSVReport, section: str) -> None:
slot_5 = helpers_ot3.get_slot_calibration_square_position_ot3(5)
home_pos = await api.gantry_position(OT3Mount.LEFT)
await api.move_to(OT3Mount.LEFT, slot_5._replace(z=home_pos.z))
for expected_state in [False, True]:
for expected_state in [True, False]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait if you switch this order but also switch the else/if order below this doesn't really do anything right? You're still expecting it to be False with no tips (but now that's second) and True with tips (but now that's first)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but actually, the responds of "get tip status" change, so the results will be different, I want to do the same action to keep the SOP same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct to me @sfoster1 . We are now first expecting True, and when it is true that means there are no tips. The ordering of the if/else is arbitrary

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Right. Sorry

print("homing...")
await api.home([ax])
if not api.is_simulator:
if expected_state:
ui.get_user_ready("remove all tips from the pipette")
else:
ui.get_user_ready("press on tips to channels A1 + H12")
else:
ui.get_user_ready("remove all tips from the pipette")
if not api.is_simulator:
init_state = await get_tip_status(api)
if init_state != EXPECTED_STATE_AT_HOME_POSITION:
Expand Down