-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labware v2: deprecate all uses of 'format' #3894
Labels
Comments
btmorr
added a commit
that referenced
this issue
Sep 10, 2019
btmorr
added a commit
that referenced
this issue
Sep 16, 2019
IanLondon
added a commit
that referenced
this issue
Sep 17, 2019
IanLondon
added a commit
that referenced
this issue
Sep 17, 2019
IanLondon
added a commit
that referenced
this issue
Sep 18, 2019
* move "well set" utils out of PD and into shared-data closes #3894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
overview
(discussed on Slack)
Labware
format
is something we’ll treat as unimportant once APIv2 is out, and we can deprecate uses of that field, so it’s fine to always be"irregular"
which means “don’t assume anything about this labware from theformat
field”.Currently,
format
is used:api/src/opentrons/legacy_api/containers/__init__.py
) to make special weird geometry compensations for rectangular wellsgetDisposalLabwareOptions
selects onlyformat === 'trash'
labware. But we don’t have anyformat: "trash"
definitions that you can add to the deck, so it’s not very useful to do that.canPipetteUseLabware
uses format to determine if labware can be used by multi-channel. All it really does is that forformat: "irregular"
definitions, it returns false and returns true for everything else. This fn is used a few places in PD, we could change it to use geometry to determine if tips will fit (this geometry logic already exists in PD and is used for liquid tracking updates)Those places will need to be changed to avoid using the format field.
The
format
key is part of the v2 labware def schema, but we can as a convention set it toirregular
for new labware defs, and otherwise ignore it. In the next labware def schema v3, we could drop theformat
field altogether; the behaviors it’s supposed to control can be captured inquirks
.The text was updated successfully, but these errors were encountered: