feat(protocol-designer): avoid use of labware "format" #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanLondon
added
protocol designer
IanLondon
force-pushed
the
pd_ignore-format
branch
from
d2bd981 to
57a97a2
Compare
Codecov Report
@@ Coverage Diff @@
## edge #4070 +/- ##
=========================================
+ Coverage 57.2% 57.89% +0.69%
=========================================
Files 851 850 -1
Lines 23975 24688 +713
=========================================
+ Hits 13714 14293 +579
- Misses 10261 10395 +134
Continue to review full report at Codecov.
|
b-cooper
approved these changes
Sep 18, 2019
shared-data/js/helpers/wellSets.js
Outdated
| @@ -0,0 +1,101 @@ | |||
| // @flow | |||
| // A "well set" is array of wells corresponding to each tip of an 8 channel pipette. | |||
There was a problem hiding this comment.
Suggested change
| // A "well set" is array of wells corresponding to each tip of an 8 channel pipette. | |
| // A "well set" is an array of wells corresponding to each tip of an 8 channel pipette. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Closes #3894 - infer multichannel compatibility from geometry instead of using
formatchangelog
formatof labware def to determine multi-channel compatibility, use geometry insteadreview requests
Make sure multi-channel & single-channel well selection still works, tube racks for example should not be compatible with multi-channel, 384 plates & reservoirs should work.
Note that the unpolished behavior PD has for handling multi-channel-incompatible labware is out of the scope of this PR. It will still allow you select wells, but will give you the blocking error:
Selected (aspirate/dispense) labware is incompatible with pipette.