Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD: Multichannel pipettes crash when dispensing to trash #3676

Closed
opatel0 opened this issue Jul 8, 2019 · 7 comments
Closed

PD: Multichannel pipettes crash when dispensing to trash #3676

opatel0 opened this issue Jul 8, 2019 · 7 comments
Labels
api Affects the `api` project bug large

Comments

@opatel0
Copy link

opatel0 commented Jul 8, 2019

overview

When dispensing to the fixed trash container on the deck, multichannel pipettes crash against the edge of the fixed trash.

current behavior

When dispensing to trash using a multichannel pipette, the multichannel is not centered in the trash and is instead positioned so that when the pipette lowers, it crashes against the southern edge of the trash bin, causing tips to fall and liquid to spill on the deck.

steps to reproduce

This issue occurred on v3.9.0 of robot server, protocol developed using v1.1.0 of PD, and with v1.3 and v1.5 p10 multi and p300 multi pipettes. In any transfer step in which the destination is the fixed trash, the pipette will collide with the fixed trash's edge.

POTENTIALLY RELATED NOTE: similar behavior can be observed with fixed trash in python protocols depending on how the command is written.
pipette.blow_out(fixed-trash) for example will result in similar behavior, but this issue can be resolved by writing the line as such: pipette.blow_out(fixed-trash[0])

expected behavior

When dispensing to the fixed trash using a multichannel pipette, the pipette should be centered in the fixed trash and avoid collision with the edge of the trash.

@IanLondon IanLondon added bug protocol designer Affects the `protocol-designer` project labels Jul 8, 2019
@IanLondon IanLondon self-assigned this Jul 8, 2019
@opatel0
Copy link
Author

opatel0 commented Jul 8, 2019

EDIT: removed protocols to retain customer privacy - please reach out to me directly for protocols

@IanLondon
Copy link
Contributor

IanLondon commented Jul 8, 2019

Confirmed that on APIv1, edge d214c5a, v3 JSON protocols still have this issue.

Note to self: this is a v2 labware in APIv1, they do not have quirks (but instead have hard-coded labware names?).

Should also confirm trough is OK.

@IanLondon
Copy link
Contributor

Also in APIv1 Python protocols, dispense to trash eg multichannel.transfer(8, samples['A1'], robot.fixed_trash['A1']) will cause an identical crash.

@btmorr btmorr added api Affects the `api` project and removed protocol designer Affects the `protocol-designer` project labels Jul 23, 2019
@umbhau umbhau removed this from the Bugs milestone Aug 26, 2019
@IanLondon IanLondon removed their assignment Sep 3, 2019
@IanLondon IanLondon added the blocked Ticket or PR is blocked by other work label Sep 3, 2019
@IanLondon
Copy link
Contributor

Blocked - requires a significant amount of APIv1 refactoring. Hopefully we can move to APIv2?

@umbhau
Copy link

umbhau commented Sep 3, 2019

Closing. Will not fix in API v1; fixed in API v2.

@umbhau umbhau closed this as completed Sep 3, 2019
@btmorr btmorr reopened this Sep 10, 2019
@btmorr
Copy link
Contributor

btmorr commented Sep 10, 2019

Changing APIv1 server to use APIv2 labware definitions allows us to fix this in an acceptable way. PR forthcoming

@btmorr btmorr removed the blocked Ticket or PR is blocked by other work label Sep 10, 2019
@btmorr
Copy link
Contributor

btmorr commented Sep 10, 2019

Oh, nevermind. I thought an in flight change was going to fix this, but this is intractable.

@btmorr btmorr closed this as completed Sep 10, 2019
@btmorr btmorr added the wontfix label Sep 10, 2019
btmorr added a commit that referenced this issue Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project bug large
Projects
None yet
Development

No branches or pull requests

4 participants