-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Settings: Expose user settings in server #1656
Labels
Milestone
Comments
btmorr
added
feature
Ticket is a feature request / PR introduces a feature
api
Affects the `api` project
medium
labels
Jun 8, 2018
Here's my pass at a spec. @btmorr and @Laura-Danielle let me know what you think fetch settingsrequest
response{
"settings": [
{
"id": "short-identifier-1",
"title": "User-facing title",
"description": "User-facing description",
"type": "boolean",
"value": true
},
{
"id": "short-identifier-2",
"title": "User-facing title",
"description": "User-facing description",
"type": "number",
"value": 42
}
]
} set settingsrequest
body{
"id": "short-identifier-1",
"value": false
} response(Same response as {
"settings": [
{
"id": "short-identifier-1",
"title": "User-facing title",
"description": "User-facing description",
"type": "boolean",
"value": false
},
{
"id": "short-identifier-2",
"title": "User-facing title",
"description": "User-facing description",
"type": "number",
"value": 42
}
]
} |
btmorr
added a commit
that referenced
this issue
Jun 29, 2018
Omitting "type" field for now--currently only supporting booleans |
btmorr
added a commit
that referenced
this issue
Jun 29, 2018
btmorr
added a commit
that referenced
this issue
Jul 2, 2018
btmorr
added a commit
that referenced
this issue
Jul 2, 2018
btmorr
added a commit
that referenced
this issue
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
overview
Run app should be able to query the server for a list of settings to include in the "Advanced Settings" page.
behavior
Schema:
There should be a GET endpoint that returns a title, long description, and current value for each setting in "feature_flags", and any other settings that we wish to expose through the advance settings page.
The text was updated successfully, but these errors were encountered: