Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run App: User Settings #1632

Closed
2 of 4 tasks
umbhau opened this issue Jun 6, 2018 · 10 comments · Fixed by #1845
Closed
2 of 4 tasks

Run App: User Settings #1632

umbhau opened this issue Jun 6, 2018 · 10 comments · Fixed by #1845
Assignees
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature medium
Milestone

Comments

@umbhau
Copy link

umbhau commented Jun 6, 2018

As a user, I would like access to settings for my Robot and Run App.

Acceptance Criteria

  • User can view 'Advanced Settings' section on Robot Settings page
  • User can view 'Advanced Settings' section on App Settings page
  • User can toggle robot-level feature flags in the Robot 'Advanced Settings' section
  • User can toggle app-level feature flags in the App 'Advanced Settings' section

Design

Zeplin > Run App Screens > 'Advanced Settings' tab

screen shot 2018-06-08 at 4 33 04 pm
screen shot 2018-06-08 at 4 32 49 pm

@umbhau umbhau added feature Ticket is a feature request / PR introduces a feature app Affects the `app` project labels Jun 6, 2018
@umbhau umbhau added this to the User Settings milestone Jun 6, 2018
@pantslakz
Copy link

hello @btmorr can you flesh out which features flags need to show under robot, and which need to show under app?

@mcous
Copy link
Contributor

mcous commented Jun 6, 2018

@pantslakz for the moment, the only one we need for app is:

  • Show dev tools (requires restart)

@pantslakz
Copy link

@mcous when user flicks this on - what do they see in the app? Do we require additional UI within the app to represent these dev tools?

@mcous
Copy link
Contributor

mcous commented Jun 7, 2018

@pantslakz, no, this just switches on the normal Chrome/Electron devtools. This is the same option that is automatically enabled when you run the application in development mode from source, so no additional UI is required

@pantslakz
Copy link

@btmorr
Copy link
Contributor

btmorr commented Jun 8, 2018

This looks fantastic. For the record, @pantslakz and I talked f2f, and the server is going to report a list of settings to expose through this panel in roughly the form:

{
  "settings": [
    {
      "title": "Calibrate to bottom of well",
      "description": "Perform labware calibration by moving the tip to the bottom-center of the well rather than the top-center (which is the default if this option is unset)",
      "value": true
    },
    {
      "title": "Other setting",
      "description": "Long description of next setting",
      "value": false
    }
  ]
}

@mcous do you have any thoughts/requests?

@mcous
Copy link
Contributor

mcous commented Jun 8, 2018

That response schema looks perfect

@btmorr
Copy link
Contributor

btmorr commented Jun 8, 2018

Ticket for the backend work: #1656

@mcous
Copy link
Contributor

mcous commented Jun 11, 2018

JK still need to do robot settings

@mcous mcous reopened this Jun 11, 2018
@mcous mcous added the api Affects the `api` project label Jun 11, 2018
@mcous mcous self-assigned this Jun 11, 2018
@umbhau umbhau added the blocked Ticket or PR is blocked by other work label Jun 19, 2018
@umbhau
Copy link
Author

umbhau commented Jun 19, 2018

@btmorr linking a ticket for blocker.

@umbhau umbhau added the medium label Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants