feat(api): Add advanced settings endpoints to api server #1786
Conversation
btmorr
added
feature
btmorr
force-pushed
the
api_adv-settings-endpoints
branch
from
83e60c2 to
7f094e1
Compare
There was a problem hiding this comment.
Looks like CI is failing, so I figured I'd put in this change request: the error response needs some tweaks to line up with existing error responses. Also, I think it's fine to pull the settings out of the error body. The app treats error responses differently from success responses, so it wouldn't know how to use settings in an error response anyway
| status = 200 | ||
| else: | ||
| res = _get_adv_settings() | ||
| res.update( |
There was a problem hiding this comment.
Sorry, should've more properly spec'd the error response. In an error case, there's no need to respond with the settings (the app stores success response and error responses separately, so they can be different shapes).
I think 400 {"message": "ID xyz not found..."} shoudl be sufficient
btmorr
force-pushed
the
api_adv-settings-endpoints
branch
from
7f094e1 to
865f866
Compare
btmorr
force-pushed
the
api_adv-settings-endpoints
branch
from
865f866 to
b2f8614
Compare
Codecov Report
@@ Coverage Diff @@
## edge #1786 +/- ##
=========================================
- Coverage 33.45% 33% -0.45%
=========================================
Files 364 366 +2
Lines 5967 6090 +123
=========================================
+ Hits 1996 2010 +14
- Misses 3971 4080 +109
Continue to review full report at Codecov.
|
overview
Add advanced settings endpoints to api server. Also added an lru_cache decorator to the "splitLabwareDefinitions" feature flag to reduce unnecessary disk IO (this is preferred anyway, as changing from old to new labware definitions without a reboot causes exceptions).
Fixes #1656
review requests
Test on robot that previously had a feature flag set to True, ensure that it remains True in new endpoint