Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Full deploy of vouching app and instantiation in ropsten using scripts. #186

Merged
merged 18 commits into from
Oct 9, 2018

Conversation

eternauta1337
Copy link
Contributor

@eternauta1337 eternauta1337 commented Oct 5, 2018

Addresses #178 Create js script to deploy vouching package contracts in a given network
and #179 Create js for bootstrapping TPL configuration

Tasklist

  • Script that pushes app to a given network.
  • Script that creates instances for BasicJurisdiction, ZEPToken, Vouching and ZEPValidator.
  • Parameterize network options.
  • Script that verifies that the deployed instances were deployed correctly.
  • Script that bootstraps the TPL configuration.
  • Script that validates the bootstrapping.

To run the scripts, see package.json's scripts for examples on how to call them with their required parameters.
npm run deploy-local (pushes the app)
npm run create-local (creates instances/proxies)
npm run configure-local (executes tpl configuration transactions)
npm run validate-local (runs a few tests on the deployed contracts)
or run them all together via:
npm run dodathing-local

The logs for running them for the ropsten network can be seen in this gist:
https://gist.github.com/ajsantander/fae7ab75e752f5176c2cd20d0838160b

NOTE: The issue suggests opening etherscan.io, interactivity, etc. but it was decided that this will be done in an external script that makes use of this script.

@facuspagnuolo facuspagnuolo self-assigned this Oct 5, 2018
@eternauta1337 eternauta1337 changed the title Full deploy of app and instantiation in ropsten using scripts. Full deploy of vouching app and instantiation in ropsten using scripts. Oct 6, 2018
Copy link
Contributor

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started with a general review and left a few comments, will continue reviewing the scripts in detail

packages/vouching/bin/create.js Outdated Show resolved Hide resolved
packages/vouching/package.json Outdated Show resolved Hide resolved
packages/vouching/scripts/create.js Outdated Show resolved Hide resolved
packages/vouching/truffle-config.js Outdated Show resolved Hide resolved
Copy link
Contributor

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/vouching/src/bin/configure.js Outdated Show resolved Hide resolved
packages/vouching/src/bin/create.js Outdated Show resolved Hide resolved
packages/vouching/src/bin/deploy.js Outdated Show resolved Hide resolved
packages/vouching/src/bin/validate.js Outdated Show resolved Hide resolved
@facuspagnuolo facuspagnuolo added the status:ready-to-merge Order mergify to merge label Oct 9, 2018
@mergify mergify bot merged commit 102c39a into master Oct 9, 2018
@eternauta1337 eternauta1337 deleted the vouching-deploy-scripts branch October 9, 2018 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready-to-merge Order mergify to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants