This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 200
Full deploy of vouching app and instantiation in ropsten using scripts. #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eternauta1337
changed the title
Full deploy of app and instantiation in ropsten using scripts.
Full deploy of vouching app and instantiation in ropsten using scripts.
Oct 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started with a general review and left a few comments, will continue reviewing the scripts in detail
eternauta1337
force-pushed
the
vouching-deploy-scripts
branch
from
October 8, 2018 15:03
38b4e3a
to
827bc0a
Compare
eternauta1337
force-pushed
the
vouching-deploy-scripts
branch
from
October 8, 2018 16:23
827bc0a
to
1821e2f
Compare
facuspagnuolo
approved these changes
Oct 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #178 Create js script to deploy vouching package contracts in a given network
and #179 Create js for bootstrapping TPL configuration
Tasklist
To run the scripts, see package.json's scripts for examples on how to call them with their required parameters.
npm run deploy-local
(pushes the app)npm run create-local
(creates instances/proxies)npm run configure-local
(executes tpl configuration transactions)npm run validate-local
(runs a few tests on the deployed contracts)or run them all together via:
npm run dodathing-local
The logs for running them for the ropsten network can be seen in this gist:
https://gist.github.com/ajsantander/fae7ab75e752f5176c2cd20d0838160b
NOTE: The issue suggests opening etherscan.io, interactivity, etc. but it was decided that this will be done in an external script that makes use of this script.