output_dir scope change allows spoiler log w/o ROM #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestRunnerSRL
pushed a commit
that referenced
this pull request
Jan 16, 2019
Move Display D-Pad HUD patch to patch_cosmetics.
Roman971
referenced
this pull request
in Roman971/OoT-Randomizer
Aug 20, 2019
Fix Triforce Piece Text ID
aplumafreak500
pushed a commit
to aplumafreak500/OoT-Randomizer
that referenced
this pull request
Feb 1, 2020
ETR-BTF
pushed a commit
to ETR-BTF/OoT-Randomizer
that referenced
this pull request
May 15, 2020
am I doing this right? lol2
flagrama
pushed a commit
to flagrama/OoT-Randomizer
that referenced
this pull request
Mar 7, 2021
…-patch-1 Restore helpers
Zannick
pushed a commit
that referenced
this pull request
Mar 4, 2022
Simplify code for individual-row note shuffle
mracsys
referenced
this pull request
in mracsys/OoT-Randomizer
Jun 20, 2022
Disable bridge goals if Ganon's Castle is shuffled
mracsys
referenced
this pull request
in mracsys/OoT-Randomizer
Jun 26, 2022
Add Tooltip for Model Selection
cjohnson57
added a commit
that referenced
this pull request
Aug 18, 2022
fenhl
pushed a commit
that referenced
this pull request
Jul 15, 2024
formatting changes for ci.py pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
output_diris scoped specifically in theif not settings.suppress_rom, which borks creating spoiler logs only without a ROM. Moving this outside of theif notblock allows creating logs without a ROM.