OBAListView iOS 14 list #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename sectionLayout to sectionLayout(:_) to use provided layoutEnvironment
AgencyAlert identifiers start from 1, 2, 3…, which is not unique for OBAListView. Uses it hash value instead of relying on agency.
Recommend synthenized Equatable conformance over manual implementation for OBAListViewItem.
Add new internal view-model for sections
Move layout configuration from section model to OBAListViewItem
Removes Separated protocol in favor of view model configuration
Make bookmarks list plain appearance
|
just noticed memory leaks. needs investigation but i think it's caused by listview caching data snapshots.
|
|
memory leak not related to this pr, opened #394 |
Merged
See OneBusAway#398, added support for iOS 14.4 for CI compatibility.
Fix CI complaining about unknown types (ugh)
aaronbrethorst
requested changes
Jun 23, 2021
There was a problem hiding this comment.
This looks like a great improvement! I noticed a couple of outstanding TODOs that you'd added that look like they still need to be taken care of. If you want to add issues for those and have me merge this, np. Otherwise let me know when they're wrapped up and I'll get this merged.
- detailButton is not being used anywhere - Clean up code and swiftlint warnings
nice work
ualch9
added a commit
to ualch9/onebusaway-ios
that referenced
this pull request
Jul 2, 2021
Fixes a OneBusAway#391 — OBAListView iOS 14 list regression
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
insetGroupedvisual style for most lists (not bookmarks, bookmark cells look too space-constrained in the new style).Shiny new visual look
References
Fixes #377
Opened:
#392
#393
#398
#399