Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain cycle of unknown cause #394

Closed
ualch9 opened this issue Jun 21, 2021 · 2 comments · Fixed by #541
Closed

Retain cycle of unknown cause #394

ualch9 opened this issue Jun 21, 2021 · 2 comments · Fixed by #541
Assignees
@ualch9
Labels
Bug

Comments

@ualch9
Copy link
Member

ualch9 commented Jun 21, 2021

Discovered while working on #391, reproducible on main branch 45d2fe6. Unsure when this was bug introduced.
Needs additional investigation, reference cycles appears to be closures associated with OBAKitCore.DecodableOperation, but I'm wondering if it's related to OBAListViewItem closures.

Screenshot attached.

image
@ualch9 ualch9 added the Bug label Jun 21, 2021
@ualch9 ualch9 added this to the Beta milestone Jun 21, 2021
This was referenced Jun 21, 2021
Merged
Merged
@aaronbrethorst aaronbrethorst modified the milestones: Beta, Post-Launch Jul 26, 2021
@aaronbrethorst
Copy link
Member

I don't think this blocks release.

@ualch9
Copy link
Member Author

ualch9 commented Jul 26, 2021 via email

@aaronbrethorst aaronbrethorst removed this from the Post-Launch milestone Aug 8, 2021
@ualch9 ualch9 self-assigned this Oct 4, 2021
ualch9 added a commit to ualch9/onebusaway-ios that referenced this issue Oct 4, 2021
@ualch9
Weakify network operation reference in StopViewController
8a06eb6 
Fixes OneBusAway#394
@ualch9 ualch9 mentioned this issue Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ualch9 ualch9

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes various retain cycles ualch9/onebusaway-ios
2 participants
@aaronbrethorst @ualch9