Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes view controller retain cycles #395

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

ualch9
Copy link
Member

@ualch9 ualch9 commented Jun 22, 2021

Fixes view controller related retain cycles, but does not fix OBAKitCore models' cycles.
Partially fixes #394.

@ualch9 ualch9 requested a review from aaronbrethorst June 22, 2021 00:31
ualch9 added 3 commits June 21, 2021 17:32
Use weak-referencing block closure for reload timer
Weakifes self references in list view actions
Weakifes self references in list view actions
Weakifes self references in list view actions
@ualch9 ualch9 force-pushed the fix_vc_retain_cycle branch from e1343ac to 63aa410 Compare June 22, 2021 00:32
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 👍

@aaronbrethorst aaronbrethorst merged commit 3d54807 into OneBusAway:master Jun 23, 2021
@ualch9 ualch9 deleted the fix_vc_retain_cycle branch July 6, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants