Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapsed sections not notifying delegate or saving state #392

Closed
ualch9 opened this issue Jun 19, 2021 · 1 comment · Fixed by #402
Closed

Collapsed sections not notifying delegate or saving state #392

ualch9 opened this issue Jun 19, 2021 · 1 comment · Fixed by #402
Assignees
@ualch9

Comments

@ualch9
Copy link
Member

ualch9 commented Jun 19, 2021

As a result of #391, OBAListView does not notify delegates of collapsed sections. This breaks saving collapsed section state.

In StopViewController, the app saves whether or not the user has collapsed service alerts.
@ualch9 ualch9 mentioned this issue Jun 23, 2021
Merged
@ualch9
Copy link
Member Author

ualch9 commented Jun 24, 2021

https://developer.apple.com/documentation/uikit/uicollectionviewdiffabledatasource/3600966-sectionsnapshothandlers

@ualch9 ualch9 self-assigned this Jun 26, 2021
ualch9 added a commit to ualch9/onebusaway-ios that referenced this issue Jun 26, 2021
@ualch9
Adopt sectionSnapshotHandlers for section collapse state in OBAListView
1f4103d 
Fixes OneBusAway#392 — Collapsed sections not notifying delegate or saving state
ualch9 added a commit to ualch9/onebusaway-ios that referenced this issue Jun 26, 2021
@ualch9
Adopt sectionSnapshotHandlers for section collapse state in OBAListView
eab68e2 
Fixes OneBusAway#392 — Collapsed sections not notifying delegate or saving state
@ualch9 ualch9 mentioned this issue Jun 26, 2021
Merged
ualch9 added a commit to ualch9/onebusaway-ios that referenced this issue Jun 28, 2021
@ualch9
Squashed commit of the following:
0d1b575 
commit f73264b
Author: Alan Chu <[email protected]>
Date:   Sat Jun 26 15:08:18 2021 -0700

    Fixes list view’s didApplyData delegate regression

    Temporaily disables arrival nudge message (OneBusAway#401)

commit 7956321
Author: Alan Chu <[email protected]>
Date:   Sat Jun 26 10:39:35 2021 -0700

    Deselects cells after being selected in OBAListView

    Fixes OneBusAway#399 — List view cells appears selected after presenting/pushing view controller

commit eab68e2
Author: Alan Chu <[email protected]>
Date:   Sat Jun 26 10:41:52 2021 -0700

    Adopt sectionSnapshotHandlers for section collapse state in OBAListView

    Fixes OneBusAway#392 — Collapsed sections not notifying delegate or saving state

commit 27a6200
Author: Alan Chu <[email protected]>
Date:   Sat Jun 26 10:03:29 2021 -0700

    Fixes recent stops item ordering

    Fixes OneBusAway#390 — Inconsistent recent stops ordering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ualch9 ualch9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes list view regressions ualch9/onebusaway-ios
1 participant
@ualch9