Fixes list view regressions #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes OneBusAway#390 — Inconsistent recent stops ordering
Fixes OneBusAway#392 — Collapsed sections not notifying delegate or saving state
Fixes OneBusAway#399 — List view cells appears selected after presenting/pushing view controller
Temporaily disables arrival nudge message (OneBusAway#401)
Addresses OneBusAway#389 by manually scrolling to the arrDeps section to maintain UX continuity when the reload is initiated by the user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #390
Fixes #392
Fixes #399
Re: #389, I am still unable to pinpoint why the list view reloads the entire list instead of applying difference updates. As a duct-tape fix, just scroll to the bottom of the arrivalsdepartures section after the data has been applied, if the user tapped the load more button.