Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing EK80 Beam_group variables #1094

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Add missing EK80 Beam_group variables #1094

merged 3 commits into from
Jul 26, 2023

Conversation

emiliom
Copy link
Collaborator

@emiliom emiliom commented Jul 26, 2023

Addresses #951

Note: flag_values and flag_meanings are CF attributes used with variables whose values are codes ("flags") that stand for specific meanings. We could stuff all that information in a comment attribute instead, but since CF already accommodates this specific situation, let's use the flag attributes.

Also added a long_name attribute to the slope variable, based on #951 (comment)

@emiliom emiliom added the enhancement This makes echopype better label Jul 26, 2023
@emiliom emiliom added this to the 0.8.0 milestone Jul 26, 2023
@emiliom emiliom requested a review from leewujung July 26, 2023 20:14
@emiliom emiliom mentioned this pull request Jul 26, 2023
Merged
8 tasks
@leewujung
Copy link
Member

Note: flag_values and flag_meanings are CF attributes used with variables whose values are codes ("flags") that stand for specific meanings. We could stuff all that information in a comment attribute instead, but since CF already accommodates this specific situation, let's use the flag attributes.

Great to learn about these!

leewujung
leewujung approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for sending this PR!

@emiliom emiliom merged commit 6fc5a1d into OSOceanAcoustics:dev Jul 26, 2023
@emiliom emiliom deleted the add-missing-ek80vars-beamgrp branch July 26, 2023 22:16
@emiliom emiliom mentioned this pull request Jul 26, 2023
Closed
lsetiawan pushed a commit to lsetiawan/echopype that referenced this pull request Jul 28, 2023
@emiliom @lsetiawan
Add missing EK80 Beam_group variables (OSOceanAcoustics#1094)
dfdd620 
* docs: remove outdated Attention box in Data Processing page

* Add 3 non-convention variables to EK80 Beam groups; add missing long_name attr to slope var
@emiliom emiliom mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leewujung leewujung leewujung approved these changes

Assignees
No one assigned
Labels
enhancement This makes echopype better
Projects
Echopype
Status: Done
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@emiliom @leewujung