Add missing EK80 Beam_group variables (#1094)

* docs: remove outdated Attention box in Data Processing page * Add 3 non-convention variables to EK80 Beam groups; add missing long_name attr to slope var
OSOceanAcoustics · Jul 26, 2023 · 6fc5a1d · 6fc5a1d
1 parent ed79cd8
commit 6fc5a1d
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 11 deletions.
diff --git a/docs/source/process.rst b/docs/source/process.rst
@@ -22,17 +22,7 @@ Functionality
 - EK80 and EA640 broadband echosounders:
 
   - Calibration based on pulse compression output in the
-    form of average over frequency (alpha).
-
-    .. attention::
-       This feature is still under development.
-       We found inconsistencies among pulse compression outputs
-       from EchoView, Matlab Echolab, and the echopype implementation, see
-       `#308 <http://https://github.com/OSOceanAcoustics/echopype/issues/308/>`_.
-       In addition, currently there are issues with calibrating files containing both
-       broadband and narrowband (the "CW mode") data, see
-       `#310 <https://github.com/OSOceanAcoustics/echopype/issues/310/>`_.
-
+    form of average over frequency.
   - The same noise removal and MVBS computation functionality available
     to the narrowband echosounders.
 

diff --git a/echopype/convert/set_groups_ek80.py b/echopype/convert/set_groups_ek80.py
@@ -901,6 +901,30 @@ def _assemble_ds_common(self, ch, range_sample_size):
                 "slope": (
                     ["ping_time"],
                     self.parser_obj.ping_data_dict["slope"][ch],
+                    {"long_name": "Hann window slope parameter for transmit signal"},
+                ),
+                "channel_mode": (
+                    ["ping_time"],
+                    np.array(self.parser_obj.ping_data_dict["channel_mode"][ch], dtype=np.byte),
+                    {
+                        "long_name": "Transceiver mode",
+                        "flag_values": [0, 1],
+                        "flag_meanings": ["Active", "Inactive"],
+                    },
+                ),
+                "pulse_form": (
+                    ["ping_time"],
+                    np.array(self.parser_obj.ping_data_dict["pulse_form"][ch], dtype=np.byte),
+                    {
+                        "long_name": "Pulse type",
+                        "flag_values": [0, 1, 5],
+                        "flag_meanings": ["CW", "FM", "FMD"],
+                    },
+                ),
+                "range_sample_offset": (
+                    ["ping_time"],
+                    np.array(self.parser_obj.ping_data_dict["offset"][ch], dtype=int),
+                    {"long_name": "First sample number"},
                 ),
             },
             coords={