Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing EK80 Beam_group variables #1094

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Add missing EK80 Beam_group variables #1094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be04921
docs: remove outdated Attention box in Data Processing page
emiliom Jul 20, 2023
f6dbff0
Merge branch 'dev' of github.com:OSOceanAcoustics/echopype into dev
emiliom Jul 24, 2023
6b578e8
Add 3 non-convention variables to EK80 Beam groups; add missing long_…
emiliom Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions docs/source/process.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,7 @@ Functionality
- EK80 and EA640 broadband echosounders:

- Calibration based on pulse compression output in the
form of average over frequency (alpha).

.. attention::
This feature is still under development.
We found inconsistencies among pulse compression outputs
from EchoView, Matlab Echolab, and the echopype implementation, see
`#308 <http://https://github.com/OSOceanAcoustics/echopype/issues/308/>`_.
In addition, currently there are issues with calibrating files containing both
broadband and narrowband (the "CW mode") data, see
`#310 <https://github.com/OSOceanAcoustics/echopype/issues/310/>`_.

form of average over frequency.
- The same noise removal and MVBS computation functionality available
to the narrowband echosounders.

Expand Down
24 changes: 24 additions & 0 deletions echopype/convert/set_groups_ek80.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,6 +901,30 @@ def _assemble_ds_common(self, ch, range_sample_size):
"slope": (
["ping_time"],
self.parser_obj.ping_data_dict["slope"][ch],
{"long_name": "Hann window slope parameter for transmit signal"},
),
"channel_mode": (
["ping_time"],
np.array(self.parser_obj.ping_data_dict["channel_mode"][ch], dtype=np.byte),
{
"long_name": "Transceiver mode",
"flag_values": [0, 1],
"flag_meanings": ["Active", "Inactive"],
},
),
"pulse_form": (
["ping_time"],
np.array(self.parser_obj.ping_data_dict["pulse_form"][ch], dtype=np.byte),
{
"long_name": "Pulse type",
"flag_values": [0, 1, 5],
"flag_meanings": ["CW", "FM", "FMD"],
},
),
"range_sample_offset": (
["ping_time"],
np.array(self.parser_obj.ping_data_dict["offset"][ch], dtype=int),
{"long_name": "First sample number"},
),
},
coords={
Expand Down