Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] mail_composer_cc_bcc_account: use _get_partner_ids_from_mail method #1450

Merged

Conversation

andrel-exo
Copy link

This fix replaces the use of deprecated methods _get_default_mail_partner_cc_ids and _get_default_mail_partner_bcc_ids with the correct method _get_partner_ids_from_mail suggested here #1312.

Impact: Without this PR, the app cannot be used. When trying to send an email from an invoice, an error occurs immediately because the old methods no longer exist.

@OCA-git-bot
Copy link
Contributor

Hi @hailangvn2023,
some modules you are maintaining are being modified, check this out!

@andrel-exo andrel-exo changed the title [17.0][FIX] use _get_partner_ids_from_mail method [17.0][FIX] mail_composer_cc_bcc_account: use _get_partner_ids_from_mail method Sep 30, 2024
Copy link
Contributor

@trisdoan trisdoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Contributor

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thx for this fix.
Technical review.
LGTM

@DorianMAG
Copy link
Contributor

@andrel-exo
Can you do a rebase to reactivate runboat and perform functional tests?
Thank you!

Copy link

@ttytm ttytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! This is indeed important to fix.

For me using this change prevents the odoo server error caused by the deprecated method. Though trying to send a mail with the cc/bcc modules activated I'm running into:

Invalid Operation

You cannot remove parts of the audit trail.

Copy link
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @pedrobaeza could you please review this? I have tested the module mail_attach_existing_attachment_account and encountered the error.

TT54708

@pedrobaeza pedrobaeza added this to the 17.0 milestone Jan 27, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1450-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command git push origin 17.0-ocabot-merge-pr-1450-by-pedrobaeza-bump-patch:17.0 failed with output:

To https://github.com/OCA/social
 ! [rejected]          17.0-ocabot-merge-pr-1450-by-pedrobaeza-bump-patch -> 17.0 (fetch first)
error: failed to push some refs to 'https://github.com/OCA/social'
hint: Updates were rejected because the remote contains work that you do not
hint: have locally. This is usually caused by another repository pushing to
hint: the same ref. If you want to integrate the remote changes, use
hint: 'git pull' before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@OCA-git-bot OCA-git-bot merged commit 22e7da4 into OCA:17.0 Jan 27, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 254363b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants