-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][FIX] mail_composer_cc_bcc_account: use _get_partner_ids_from_mail method #1450
[17.0][FIX] mail_composer_cc_bcc_account: use _get_partner_ids_from_mail method #1450
Conversation
…od _get_default_mail_partner_*
Hi @hailangvn2023, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thx for this fix.
Technical review.
LGTM
@andrel-exo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this! This is indeed important to fix.
For me using this change prevents the odoo server error caused by the deprecated method. Though trying to send a mail with the cc/bcc modules activated I'm running into:
Invalid Operation
You cannot remove parts of the audit trail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @pedrobaeza could you please review this? I have tested the module mail_attach_existing_attachment_account
and encountered the error.
TT54708
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch
On my way to merge this fine PR! |
@pedrobaeza The merge process could not be finalized, because command
|
Congratulations, your PR was merged at 254363b. Thanks a lot for contributing to OCA. ❤️ |
This fix replaces the use of deprecated methods
_get_default_mail_partner_cc_ids
and_get_default_mail_partner_bcc_ids
with the correct method_get_partner_ids_from_mail
suggested here #1312.Impact: Without this PR, the app cannot be used. When trying to send an email from an invoice, an error occurs immediately because the old methods no longer exist.