[17.0][mig] mail_template_attach_existing_attachment_account #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module, based on allow to define _ to pre-select existing attachment that matched with file name to send in compose mail. This module is designed to work in mass mailing to select proper files to attached from mail template configuration. reviews: Co-authored-by: Hpar <[email protected]> Co-authored-by: Marc Hertzog <[email protected]>
This is the same feature as [mail_template_attach_existing_attachment]( OCA#1005) for account module to send invoice by email with existing attachemnts
damdam-s
force-pushed
the
17.0-mig-mail_template_attach_existing_attachment_account
branch
3 times, most recently
from
c639270 to
6c8f7c8
Compare
damdam-s
force-pushed
the
17.0-mig-mail_template_attach_existing_attachment_account
branch
from
a22ce6c to
3899c10
Compare
|
another module ( |
petrus-v
approved these changes
Jan 24, 2025
|
This should not merged as it !... @damdam-s I've the felling it's easier to maintain migration PR using test-requirements.txt and also make sure your work pass test while depending on other ongoing PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #1543