[MIG] account invoicing mode: Migration to 14.0 #844

phuctranfxvn · 2021-01-11T14:13:44Z

This PR includes migration of 3 modules from this PR #755:

account_invoice_base_invoicing_mode
account_invoice_mode_at_shipping
account_invoice_mode_monthly

Add three modules helping on automatically invoicing customers. The base module `account_invoice_base_invoicing_mode` does not actually do anything but adds a selection field on partner to allow assigning an invoicing mode to a customer. And a checkbox to choose regrouping invoices. The two other modules add specific invoicing mode. The module `account_invoice_mode_monthly` creates monthly invoices for customer on a specific day (configuration is in Accounting Settings) The module `account_invoice_mode_at_shipping` creates invoices on the shipping of the goods. Those modules use queue_job to generate and validate invoices.

Add few changes from reviews. Use sudo to post the invoice.

Add three modules helping on automatically invoicing customers. The base module `account_invoice_base_invoicing_mode` does not actually do anything but adds a selection field on partner to allow assigning an invoicing mode to a customer. And a checkbox to choose regrouping invoices. The two other modules add specific invoicing mode. The module `account_invoice_mode_monthly` creates monthly invoices for customer on a specific day (configuration is in Accounting Settings) The module `account_invoice_mode_at_shipping` creates invoices on the shipping of the goods. Those modules use queue_job to generate and validate invoices.

Sales order with different payment term are not grouped into the same invoice anymore. This grouping can be easily changed by overriding the coresponding method. During this change the parameter of the job generating the invoices has changes and is now the sale_order_ids to process.

Add few changes from reviews. Use sudo to post the invoice.

Add three modules helping on automatically invoicing customers. The base module `account_invoice_base_invoicing_mode` does not actually do anything but adds a selection field on partner to allow assigning an invoicing mode to a customer. And a checkbox to choose regrouping invoices. The two other modules add specific invoicing mode. The module `account_invoice_mode_monthly` creates monthly invoices for customer on a specific day (configuration is in Accounting Settings) The module `account_invoice_mode_at_shipping` creates invoices on the shipping of the goods. Those modules use queue_job to generate and validate invoices.

If we group several sales in the same procurement group, we'll invoice only one sale order. Tracing back to the sales through the stock moves ensure we invoice all of them.

Through the stock moves

Add few changes from reviews. Use sudo to post the invoice.

fshah-initos · 2021-03-26T07:14:04Z

Hi @phuctranerp
Please create seperate PR for other modules we use only one module in a PR.

tarbib · 2021-06-09T09:01:17Z

Hello @TDu could you please review the PR? cc @jgrandguillaume

TDu · 2021-06-16T07:07:45Z

account_invoice_mode_at_shipping/models/stock_picking.py

        for picking in self:
            if picking._invoice_at_shipping():
                picking.with_delay()._invoicing_at_shipping()
        return res

    def _invoice_at_shipping(self):
-        """Check if picking must be invoiced at shipping."""
+        """Check if picking must be invoiced at shippin`g."""


"""Check if picking must be invoiced at shipping."""

TDu

LG, thanks for the migration.

TDu · 2021-06-16T07:13:50Z

Hi @phuctranerp
Please create seperate PR for other modules we use only one module in a PR.

I think it is good like this in one PR, because they are tightly related.
And this is how they have been proposed for v13, where they have not been merged.

tarbib · 2021-06-23T15:43:15Z

@TDu Hello, I just tested it on v14 but there's an issue :
Commercial partner : Company A => invoicing mode : at shipping
Contact : Company A, Contact 1 => accounting tab says that configuration is done on the parent.
If the partner_invoice_id from the SO is a contact then we do not have automatic invoicing at shipping.
The contact should inherit the value from the commercial partner.
Can you please take this case into consideration? cc @jcoux

TDu · 2021-06-24T13:07:47Z

@tarbib Indeed the fields should be added to the commercial_fields of the res.partner
Something like this on the res.partner model

@api.model
def _commercial_fields(self):
         return super()._commercial_fields() + [
             "invoicing_mode",
             "one_invoice_per_order",
         ]

That would be a good addition to those modules

simahawk

please rebase (well, replay all commits) on v13.0 as @TDu squashed commits.

simahawk · 2021-08-03T07:15:56Z

@phuctranerp if you preferer we can merge 13.0 version in 14.0 and make it uninstallable as we've done for postlogistics PR 😉

simahawk · 2021-08-03T14:44:00Z

#983

TDu and others added 16 commits January 10, 2021 19:20

fixup! [13.0]]ADD] Add acconut_invoicing_mode

c612d36

[13.0][FIX] Add acconut_invoicing_mode

9eaab8e

Add few changes from reviews. Use sudo to post the invoice.

fixup! [13.0]]ADD] Add acconut_invoicing_mode

dcb9964

fixup! fixup! [13.0]]ADD] Add acconut_invoicing_mode

2be7ae7

[13.0][FIX] Add acconut_invoicing_mode

c12a85c

Add few changes from reviews. Use sudo to post the invoice.

fixup! [13.0]]ADD] Add acconut_invoicing_mode

26420be

fixup! fixup! [13.0]]ADD] Add acconut_invoicing_mode

747917a

Invoice sales based on moves

13e318c

If we group several sales in the same procurement group, we'll invoice only one sale order. Tracing back to the sales through the stock moves ensure we invoice all of them.

Ensure _get_related_invoices include all the related invoices

67a2d3e

Through the stock moves

[13.0][FIX] Add acconut_invoicing_mode

b01e0a9

Add few changes from reviews. Use sudo to post the invoice.

[IMP] account_invoice_mode: black, isort, prettier

2b10496

[MIG] account_invoice_mode: Migration to 14.0

932053f

phuctranfxvn force-pushed the 14.0-mig-invoicing-mode branch from 7587dd8 to 932053f Compare January 11, 2021 14:24

TDu reviewed Jun 16, 2021

View reviewed changes

TDu approved these changes Jun 16, 2021

View reviewed changes

jcoux mentioned this pull request Jun 28, 2021

[14.0][ADD] account_invoice_mode_weekly #964

Merged

ivantodorovich mentioned this pull request Jul 21, 2021

[14.0][ADD] shopinvader_customer_invoicing_mode shopinvader/odoo-shopinvader#1033

Merged

SilvioC2C mentioned this pull request Aug 3, 2021

[FIX] Manage res.partner commercial fields, set Selection fields' ondelete attribute trobz/account-invoicing#1

Closed

simahawk requested changes Aug 3, 2021

View reviewed changes

simahawk mentioned this pull request Aug 3, 2021

[MIG] account_invoicing_mode*: Migration to 14.0 #983

Merged

simahawk closed this Aug 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] account invoicing mode: Migration to 14.0 #844

[MIG] account invoicing mode: Migration to 14.0 #844

phuctranfxvn commented Jan 11, 2021

fshah-initos commented Mar 26, 2021

tarbib commented Jun 9, 2021

TDu Jun 16, 2021

TDu left a comment

TDu commented Jun 16, 2021 •

edited

Loading

tarbib commented Jun 23, 2021

TDu commented Jun 24, 2021

simahawk left a comment

simahawk commented Aug 3, 2021

simahawk commented Aug 3, 2021

[MIG] account invoicing mode: Migration to 14.0 #844

[MIG] account invoicing mode: Migration to 14.0 #844

Conversation

phuctranfxvn commented Jan 11, 2021

fshah-initos commented Mar 26, 2021

tarbib commented Jun 9, 2021

TDu Jun 16, 2021

Choose a reason for hiding this comment

TDu left a comment

Choose a reason for hiding this comment

TDu commented Jun 16, 2021 • edited Loading

tarbib commented Jun 23, 2021

TDu commented Jun 24, 2021

simahawk left a comment

Choose a reason for hiding this comment

simahawk commented Aug 3, 2021

simahawk commented Aug 3, 2021

TDu commented Jun 16, 2021 •

edited

Loading