[13.0]]ADD] Add account_invoicing_mode #755

TDu · 2020-07-14T08:48:35Z

Add three modules helping on automatically invoicing customers.

The base module account_invoice_base_invoicing_mode does not actually
do anything but adds a selection field on partner to allow assigning an
invoicing mode to a customer.

The two other modules add specific invoicing mode.

The module account_invoice_mode_monthly creates monthly invoices for
customer on a specific day (configruation is in Accounting Settings)

The module account_invoice_mode_at_shipping creates invoices on the
shipping of the goods.

Those modules use queue_job to generate and validate invoices.

jgrandguillaume

Functional test, looks good. Thx for the job

jbaudoux

Some remarks (typo, refunds)

account_invoice_mode_monthly/data/ir_cron.xml

account_invoice_mode_monthly/models/sale_order.py

account_invoice_base_invoicing_mode/models/sale_order.py

jbaudoux

Some additional remarks to be compatible with the module https://github.com/OCA/stock-logistics-workflow/tree/13.0/stock_picking_group_by_partner_by_carrier

account_invoice_mode_at_shipping/models/stock_picking.py

account_invoice_base_invoicing_mode/tests/test_base_invoicing_mode.py

account_invoice_mode_monthly/models/sale_order.py

pedrobaeza · 2020-07-23T06:49:14Z

I think this module is not correctly focused by several reasons:

The aim is to invoice sales order, so the name and the repo are not good.
It's overlapping sale_automatic_workflow flow.

IMO, you should extend that module for adding the monthly/dayly mechanism, but using the same base methods.

account_invoice_base_invoicing_mode/models/sale_order.py

account_invoice_mode_at_shipping/models/stock_picking.py

account_invoice_mode_at_shipping/tests/test_invoice_mode_at_shipping.py

account_invoice_mode_monthly/models/sale_order.py

account_invoice_mode_at_shipping/models/stock_picking.py

TDu · 2021-07-22T07:44:15Z

In previous comments there has been a suggestion by @pedrobaeza to include this into sale_automatic_workflow because the use case is overlapping with it.
I don't think so myself, the monthly invoice mode is based on a daily cron, the option does not exist in sale_automatic_workflow and the at shipping invoicing is triggered by some specific code in the action_done of the stock_picking, which would not be easily implemented on top of sale_automatic_workflow.

Moreover the proposed change would also make this pr much more complex and maybe its UI element less intuitive to use.

And I personally think that this pr gives a good base to add different invoicing mode in the future.

pedrobaeza · 2021-07-22T07:46:06Z

I don't remember right now my suggestion and the context, so I can't give you now an answer, but if you point me to it, I can agree or not on this.

TDu · 2021-07-22T07:48:02Z

@pedrobaeza It is about this comment #755 (comment) on the same PR.
We would like to get this merge and I felt your proposition still deserved an answer, yep that is one year ago.

sebalix

LG, a rebase to keep one commit / module is welcome

pedrobaeza · 2021-07-22T07:51:18Z

OK, as you prefer then. I still encounter some common points:

sale_automatic_workflow also has a cron that performs the task of invoicing.
It contains the code to invoice.

What about the naming, being sale_invoicing_mode or similar?

TDu · 2021-07-22T07:59:07Z

OK, as you prefer then. I still encounter some common points:
* `sale_automatic_workflow` also has a cron that performs the task of invoicing.

* It contains the code to invoice.
What about the naming, being sale_invoicing_mode or similar?

Well the base module is just a field on the partner really, so it is about invoicing first. So it could be used to invoice other things than a sale order if the business model requires that.

I would really like to keep the naming like it is.

pedrobaeza · 2021-07-22T08:15:35Z

What about partner_invoicing_mode then? If not, I won't block it.

TDu · 2021-07-22T08:47:11Z

What about partner_invoicing_mode then? If not, I won't block it.

I actually like that name better, shorter and more explicit.
Maybe it could be renamed during the 14.0 migration

Add three modules helping on automatically invoicing customers. The base module `account_invoice_base_invoicing_mode` does not actually do anything but adds a selection field on partner to allow assigning an invoicing mode to a customer. And a checkbox to choose regrouping invoices. The two other modules add specific invoicing mode. The module `account_invoice_mode_monthly` creates monthly invoices for customer on a specific day (configuration is in Accounting Settings) The module `account_invoice_mode_at_shipping` creates invoices on the shipping of the goods. Those modules use queue_job to generate and validate invoices.

Sales order with different payment term are not grouped into the same invoice anymore. This grouping can be easily changed by overriding the coresponding method. During this change the parameter of the job generating the invoices has changes and is now the sale_order_ids to process.

If we group several sales in the same procurement group, we'll invoice only one sale order. Tracing back to the sales through the stock moves ensure we invoice all of them.

Through the stock moves

Add few changes from reviews. Use sudo to post the invoice.

TDu · 2021-07-28T08:16:04Z

@simahawk I squashed the commit and added the roadmap as discussed

simahawk · 2021-07-28T13:24:39Z

@TDu check the build pls

simahawk

@jbaudoux @mmequignon good for you?

mmequignon · 2021-07-29T06:41:56Z

account_invoice_base_invoicing_mode/models/account_invoice.py

+class AccountMove(models.Model):
+    _inherit = "account.move"
+
+    @job(default_channel="root.invoice_validation")


Isn't the @job decorator deprecated?
OCA/queue#274

Yes it is, but it still works for v13.
It will be changed on the v14 migration.

simahawk · 2021-07-29T12:26:20Z

/ocabot merge patch

OCA-git-bot · 2021-07-29T12:26:27Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-755-by-simahawk-bump-patch, awaiting test results.

Signed-off-by simahawk

simahawk · 2021-08-02T05:29:10Z

/ocabot merge patch

OCA-git-bot · 2021-08-02T05:29:24Z

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-755-by-simahawk-bump-patch, awaiting test results.

Signed-off-by simahawk

OCA-git-bot · 2021-08-02T05:48:57Z

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-755-by-simahawk-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

simahawk · 2021-08-02T05:50:21Z

WTH?

sbidoul · 2021-08-02T12:41:42Z

If you click on the link in the error message, you'll see that travis is indeed red (a transient GitHub error). It is not the same commit as the one just above for a good reason I don't remember right now.

simahawk · 2021-08-03T08:41:58Z

let's try again
/ocabot merge patch

OCA-git-bot · 2021-08-03T08:42:08Z

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-755-by-simahawk-bump-patch, awaiting test results.

OCA-git-bot · 2021-08-03T09:10:12Z

Congratulations, your PR was merged at 5faf8c4. Thanks a lot for contributing to OCA. ❤️

The related PR on the OCA is * OCA/account-invoicing#755 BSCOS-466

TDu force-pushed the invoicing-mode-13 branch 3 times, most recently from e463d8f to 14ff383 Compare July 15, 2020 16:36

jgrandguillaume approved these changes Jul 16, 2020

View reviewed changes

jbaudoux suggested changes Jul 16, 2020

View reviewed changes

jbaudoux reviewed Jul 16, 2020

View reviewed changes

account_invoice_base_invoicing_mode/models/sale_order.py Outdated Show resolved Hide resolved

jbaudoux suggested changes Jul 16, 2020

View reviewed changes

account_invoice_base_invoicing_mode/models/sale_order.py Show resolved Hide resolved

rvalyi changed the title ~~[13.0]]ADD] Add acconut_invoicing_mode~~ [13.0]]ADD] Add account_invoicing_mode Jul 16, 2020

pedrobaeza mentioned this pull request Jul 16, 2020

[12.0] Is there an addon to auto-invoice the orders? #760

Closed

jbaudoux reviewed Jul 16, 2020

View reviewed changes

account_invoice_mode_at_shipping/models/stock_picking.py Outdated Show resolved Hide resolved

account_invoice_mode_at_shipping/models/stock_picking.py Outdated Show resolved Hide resolved

mmequignon reviewed Jul 20, 2020

View reviewed changes

account_invoice_base_invoicing_mode/tests/test_base_invoicing_mode.py Outdated Show resolved Hide resolved

account_invoice_mode_monthly/models/sale_order.py Show resolved Hide resolved

simahawk requested changes Sep 9, 2020

View reviewed changes

i-vyshnevska reviewed Sep 23, 2020

View reviewed changes

account_invoice_mode_at_shipping/models/stock_picking.py Outdated Show resolved Hide resolved

phuctranfxvn mentioned this pull request Jan 11, 2021

[MIG] account invoicing mode: Migration to 14.0 #844

Closed

TDu force-pushed the invoicing-mode-13 branch from f0b8724 to 4f0438a Compare April 27, 2021 05:08

jbaudoux reviewed Apr 28, 2021

View reviewed changes

account_invoice_mode_at_shipping/models/stock_picking.py Show resolved Hide resolved

sebalix approved these changes Jul 22, 2021

View reviewed changes

TDu and others added 5 commits July 28, 2021 09:59

Invoice sales based on moves

2ef6676

If we group several sales in the same procurement group, we'll invoice only one sale order. Tracing back to the sales through the stock moves ensure we invoice all of them.

Ensure _get_related_invoices include all the related invoices

2525a0a

Through the stock moves

[13.0][FIX] Add acconut_invoicing_mode

5ad9ef5

Add few changes from reviews. Use sudo to post the invoice.

TDu force-pushed the invoicing-mode-13 branch from 29d10d4 to 4b428b3 Compare July 28, 2021 08:15

[13.0] account-invoicing-mode add roadmap

f15e7de

TDu force-pushed the invoicing-mode-13 branch from 4b428b3 to f15e7de Compare July 29, 2021 02:24

simahawk approved these changes Jul 29, 2021

View reviewed changes

mmequignon reviewed Jul 29, 2021

View reviewed changes

mmequignon approved these changes Jul 29, 2021

View reviewed changes

OCA-git-bot added a commit that referenced this pull request Jul 29, 2021

Merge PR #755 into 13.0

5125be3

Signed-off-by simahawk

OCA-git-bot added the bot is merging ⏳ label Jul 29, 2021

jbaudoux approved these changes Aug 1, 2021

View reviewed changes

OCA-git-bot added the approved label Aug 1, 2021

OCA-git-bot added a commit that referenced this pull request Aug 2, 2021

Merge PR #755 into 13.0

4c28f6c

Signed-off-by simahawk

OCA-git-bot removed the bot is merging ⏳ label Aug 2, 2021

OCA-git-bot added the bot is merging ⏳ label Aug 3, 2021

OCA-git-bot merged commit 2d754d3 into OCA:13.0 Aug 3, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 3, 2021

kv1612 pushed a commit to kv1612/partner-contact that referenced this pull request Oct 19, 2021

Add Monthly and At Shipping invoicing mode

0275c39

The related PR on the OCA is * OCA/account-invoicing#755 BSCOS-466

rafaelbn mentioned this pull request Dec 13, 2022

[15.0][MIG] account_invoice_base_invoicing_mode (renamed) #1243

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0]]ADD] Add account_invoicing_mode #755

[13.0]]ADD] Add account_invoicing_mode #755

TDu commented Jul 14, 2020

jgrandguillaume left a comment

jbaudoux left a comment

jbaudoux left a comment

pedrobaeza commented Jul 23, 2020

TDu commented Jul 22, 2021

pedrobaeza commented Jul 22, 2021

TDu commented Jul 22, 2021

sebalix left a comment

pedrobaeza commented Jul 22, 2021

TDu commented Jul 22, 2021 •

edited

Loading

pedrobaeza commented Jul 22, 2021

TDu commented Jul 22, 2021

TDu commented Jul 28, 2021

simahawk commented Jul 28, 2021

simahawk left a comment

mmequignon Jul 29, 2021

TDu Jul 29, 2021

simahawk commented Jul 29, 2021

OCA-git-bot commented Jul 29, 2021

simahawk commented Aug 2, 2021

OCA-git-bot commented Aug 2, 2021

OCA-git-bot commented Aug 2, 2021

simahawk commented Aug 2, 2021

sbidoul commented Aug 2, 2021

simahawk commented Aug 3, 2021

OCA-git-bot commented Aug 3, 2021

OCA-git-bot commented Aug 3, 2021

[13.0]]ADD] Add account_invoicing_mode #755

[13.0]]ADD] Add account_invoicing_mode #755

Conversation

TDu commented Jul 14, 2020

jgrandguillaume left a comment

Choose a reason for hiding this comment

jbaudoux left a comment

Choose a reason for hiding this comment

jbaudoux left a comment

Choose a reason for hiding this comment

pedrobaeza commented Jul 23, 2020

TDu commented Jul 22, 2021

pedrobaeza commented Jul 22, 2021

TDu commented Jul 22, 2021

sebalix left a comment

Choose a reason for hiding this comment

pedrobaeza commented Jul 22, 2021

TDu commented Jul 22, 2021 • edited Loading

pedrobaeza commented Jul 22, 2021

TDu commented Jul 22, 2021

TDu commented Jul 28, 2021

simahawk commented Jul 28, 2021

simahawk left a comment

Choose a reason for hiding this comment

mmequignon Jul 29, 2021

Choose a reason for hiding this comment

TDu Jul 29, 2021

Choose a reason for hiding this comment

simahawk commented Jul 29, 2021

OCA-git-bot commented Jul 29, 2021

simahawk commented Aug 2, 2021

OCA-git-bot commented Aug 2, 2021

OCA-git-bot commented Aug 2, 2021

simahawk commented Aug 2, 2021

sbidoul commented Aug 2, 2021

simahawk commented Aug 3, 2021

OCA-git-bot commented Aug 3, 2021

OCA-git-bot commented Aug 3, 2021

TDu commented Jul 22, 2021 •

edited

Loading