Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] shopinvader_customer_invoicing_mode #1033

Merged

Conversation

ivantodorovich
Copy link
Contributor

@ivantodorovich ivantodorovich commented Jul 20, 2021

This module exposes to the customer service the invoicing_mode field added by OCA module account_invoice_base_invoicing_mode .

Depends on:

⚠️ Do not merge until dependency's merged and test-requirement removed ⚠️

@ivantodorovich ivantodorovich force-pushed the 14.0-add-invoicing-mode branch from 20b70b0 to 595766b Compare July 21, 2021 11:43
@ivantodorovich
Copy link
Contributor Author

Hello, tests are failing due to:

ERROR: Could not find a version that satisfies the requirement odoo14-addon-account_invoice_base_invoicing_mode (from versions: none)
ERROR: No matching distribution found for odoo14-addon-account_invoice_base_invoicing_mode

I'm from the old oca_dependencies.txt school 😅 I'm not sure what the process is to include this dep.
Should I add it to the test-requirements.txt file? I don't see the other OCA deps there, so.. not so sure

@simahawk
Copy link
Contributor

is that module published? If yes it should be found on pypi

@ivantodorovich
Copy link
Contributor Author

My bad, I thought the module was merged but in fact it's not. I've just added the PR dependency 😅

@sebastienbeau
Copy link
Contributor

LGTM (code review) just need to wait for the dependency to be fixed and merged

@sebastienbeau sebastienbeau added this to the 14.0 milestone Jul 21, 2021
test-requirements.txt Outdated Show resolved Hide resolved
@ivantodorovich ivantodorovich force-pushed the 14.0-add-invoicing-mode branch from 370beb3 to 595766b Compare August 4, 2021 12:08
@simahawk
Copy link
Contributor

simahawk commented Aug 4, 2021

/ocabot merge nobump

@shopinvader-git-bot
Copy link

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1033-by-simahawk-bump-nobump, awaiting test results.

@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 29579a2. Thanks a lot for contributing to shopinvader. ❤️

@ivantodorovich ivantodorovich deleted the 14.0-add-invoicing-mode branch August 17, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants