Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-cash: 4.3.1 -> 4.4.1 #352956

Closed
wants to merge 5 commits into from
Closed

Conversation

itepastra
Copy link
Member

@itepastra itepastra commented Nov 1, 2024

Should be merged after

Things I did:

  • electron-cash: format using nixfmt
  • electron-cash: use --replace-fail instead of --replace
  • electron-cash: remove with lib; from meta
  • electron-cash: 4.3.1 -> 4.4.1
  • electron-cash: move to by-name

I cannot seem to make it load libsecp256k1 since nix provides secp256k1.so.2 and electron-cash expects secp256k1.so.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@itepastra itepastra added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 1, 2024
@ofborg ofborg bot requested review from layus, Lassulus, oxalica and nyanloutre November 2, 2024 05:12
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 2, 2024
@sivizius
Copy link
Contributor

Duplicate of #346047

@itepastra
Copy link
Member Author

I hadn't seen, will close this pr

@itepastra itepastra closed this Nov 10, 2024
@itepastra itepastra deleted the electron-cash branch November 10, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants