electron-cash: 4.3.1 -> 4.4.1

[ocfox]

Things done

Fix https://hydra.nixos.org/build/272621155

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[momeemt]

Result of nixpkgs-review pr 346047 run on aarch64-darwin 1

2 packages built:

• electron-cash
• electron-cash.dist

[momeemt]

LGTM 👍

[oxalica]

I got a warning about missing libsecp256k1. It seems that preFixup is not working correctly?

Stdout:

[secp256k1] warning: libsecp256k1 library failed to load
[secp256k1] warning: loading from /nix/store/smd8vskf6l15jq2pzkw7ya1ywg722i4z-electron-cash-4.4.1/lib/python3.12/site-packages/electroncash/libsecp256k1.so.0 failed with: <class 'OSError'>
[secp256k1] warning: loading from libsecp256k1.so.0 failed with: <class 'OSError'>
[ecc] info: libsecp256k1 library not available, falling back to python-ecdsa. This means signing operations will be slower. Try running:

  $  contrib/make_secp

(You need to be running from the git sources for contrib/make_secp to be available)


zxing-cpp module missing. Please try installing it with: python3 -m pip install 'zxing-cpp>=2.2.0' --user

That absolute so path really does not exist.